Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Should throw error when unknown permission is requested #27

Closed
danfinlay opened this issue Sep 20, 2019 · 1 comment · Fixed by #87
Closed

Should throw error when unknown permission is requested #27

danfinlay opened this issue Sep 20, 2019 · 1 comment · Fixed by #87
Assignees

Comments

@danfinlay
Copy link
Collaborator

Like a method not found error, maybe? Or do we want to support partial-resolutions? Might be nice to fail-hard by default, but allow a dapp to provide a parameter specifying that it's okay if a feature isn't supported, just leave it out?

Currently we display any unknown permissions to the user, and that's bad, b/c they could approve something that eventually becomes a permission.

@rekmarks
Copy link
Member

rekmarks commented Nov 2, 2019

I'm not sure if the "unknown permissions" are plugin-specific or dapp-specific. Please see the following PR: #87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants