Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!metamodels-tng-branch config.php produces invalid HTML ID #810

Closed
Aybee opened this issue May 15, 2015 · 4 comments
Closed

!metamodels-tng-branch config.php produces invalid HTML ID #810

Aybee opened this issue May 15, 2015 · 4 comments
Labels
wrong repository This ticket is in the wrong repository and should get moved.

Comments

@Aybee
Copy link

Aybee commented May 15, 2015

$GLOBALS['BE_MOD']['Nightly builds']['BackendModule_446df1d8536436f29587dcf24ddac2f8'] = array(
    'callback' => 'BackendModule_446df1d8536436f29587dcf24ddac2f8',
    'icon'     => 'system/themes/default/images/modules.gif',
);

results in

<li id="Nightly builds" class="tl_parent">

You can use this one

$GLOBALS['BE_MOD']['nightlyBuilds']['BackendModule_446df1d8536436f29587dcf24ddac2f8'] = array(
    'callback' => 'BackendModule_446df1d8536436f29587dcf24ddac2f8',
    'icon'     => 'system/themes/default/images/modules.gif',
);
$GLOBALS['TL_LANG']['MOD']['nightlyBuilds'] = 'Nightly Builds';

Wird !metamodels-tng-branch eigentlich hier auf github verwaltet, oder kann ich das nicht finden, weil das dynamisch erzeugt wird? Kann ich bei der manuellen Installation ohne Composer auch auf diesen Ordner verzichten?

@discordier
Copy link
Member

  1. Is this still valid? If so, can you explain in more detail what the problem is? Is the backend menu broken?
  2. How to reproduce? For me it renders just fine in the backend.
  3. The module !metamodels-tng-branch is generated by the nightly build job via https://github.com/cyberspectrum/nightly-builder and therefore has no custom repository on it's own.

@Aybee
Copy link
Author

Aybee commented Jun 27, 2015

Do you have this ID in BE? "Nightly builds"? This is an invalid ID.

Seems that the ID gets build from this key $GLOBALS['BE_MOD']['Nightly builds']. That's why I proposed to rename this key to $GLOBALS['BE_MOD']['nightlyBuilds'].

I can not reproduce why and in which situation I stumbled upon this invalid ID.

@discordier
Copy link
Member

I created an issue at cyberspectrum/nightly-builder#8

@discordier discordier added the wrong repository This ticket is in the wrong repository and should get moved. label Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wrong repository This ticket is in the wrong repository and should get moved.
Projects
None yet
Development

No branches or pull requests

2 participants