From 878114e2192a00015ae02a8deae5b67e3f613fdb Mon Sep 17 00:00:00 2001 From: "nicolas.dorier" Date: Wed, 16 Feb 2022 15:05:54 +0900 Subject: [PATCH] Remove useless code --- NBitcoin/Crypto/ECKey.cs | 7 ++----- NBitcoin/PubKey.cs | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/NBitcoin/Crypto/ECKey.cs b/NBitcoin/Crypto/ECKey.cs index 30b600956a..25e6d96b0c 100644 --- a/NBitcoin/Crypto/ECKey.cs +++ b/NBitcoin/Crypto/ECKey.cs @@ -114,7 +114,7 @@ public ECPublicKeyParameters GetPublicKeyParameters() } } - public static ECKey RecoverFromSignature(int recId, ECDSASignature sig, uint256 message, bool compressed) + public static ECKey RecoverFromSignature(int recId, ECDSASignature sig, uint256 message) { if (recId < 0) throw new ArgumentException("recId should be positive"); @@ -182,10 +182,7 @@ public static ECKey RecoverFromSignature(int recId, ECDSASignature sig, uint256 var eInvrInv = rInv.Multiply(eInv).Mod(n); ECPoint q = ECAlgorithms.SumOfTwoMultiplies(curve.G, eInvrInv, R, srInv); q = q.Normalize(); - if (compressed) - { - q = new SecP256K1Point(curve.Curve, q.XCoord, q.YCoord, true); - } + q = new SecP256K1Point(curve.Curve, q.XCoord, q.YCoord, true); return new ECKey(q.GetEncoded(), false); } private static ECPoint DecompressKey(NBitcoin.BouncyCastle.Math.BigInteger xBN, bool yBit) diff --git a/NBitcoin/PubKey.cs b/NBitcoin/PubKey.cs index cb09f859f1..04d98114f0 100644 --- a/NBitcoin/PubKey.cs +++ b/NBitcoin/PubKey.cs @@ -463,7 +463,7 @@ public static PubKey RecoverCompact(uint256 hash, CompactSignature compactSignat #pragma warning disable 618 var sig = new ECDSASignature(r, s); #pragma warning restore 618 - ECKey key = ECKey.RecoverFromSignature(compactSignature.RecoveryId, sig, hash, true); + ECKey key = ECKey.RecoverFromSignature(compactSignature.RecoveryId, sig, hash); return key.GetPubKey(true); #endif }