Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AspNetCore Package: ExcludeErrorsFromLocal is not respected #430

Open
bakermo opened this issue Jun 15, 2020 · 4 comments
Open

AspNetCore Package: ExcludeErrorsFromLocal is not respected #430

bakermo opened this issue Jun 15, 2020 · 4 comments

Comments

@bakermo
Copy link

bakermo commented Jun 15, 2020

Hello there!

We are utilizing the Mindscape.Raygun4Net.AspNetCore package and have discovered that ExcludeErrorsFromLocal on RaygunSettings is only being referenced by RaygunAspNetMiddleware:
https://github.com/MindscapeHQ/raygun4net/blob/c464d6da64e54996d8644f5ba920d9aec1158ec2/Mindscape.Raygun4Net.AspNetCore/RaygunAspNetMiddleware.cs#L81

There is no check against this setting in RaygunClient.cs, so any direct calls to Send() or SendInBackground() will send the exception even from local origins.

It appears this setting was working correctly in Mindscape.Raygun4Net.

@Loubear111
Copy link

It is a couple years later but I noticed I am having this exact same issue.

@phillip-haydon
Copy link
Contributor

Hello @Loubear111,

We are slowly chipping away at the issues list, we will try bump this one up sooner.

@Loubear111
Copy link

@phillip-haydon That's great! I may have time to dig into this at some point as well and submit a PR if I do actually end up digging into it.

@phillip-haydon
Copy link
Contributor

Hello @Loubear111, I'm happy for you to take a stab at it, I'll be away for a couple of weeks, back October 14th, and will pick this up then, implementation or reviewing. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants