Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with toml package when deploying project #1246

Open
alfonsomhc opened this issue Nov 17, 2017 · 6 comments
Open

Error with toml package when deploying project #1246

alfonsomhc opened this issue Nov 17, 2017 · 6 comments

Comments

@alfonsomhc
Copy link

alfonsomhc commented Nov 17, 2017

I get this error when I deploy my project:

Packaging project as gzipped tarball.
  Could not find a version that satisfies the requirement toml==0.9.3 (from versions: 0.6.0, 0.6.5, 0.7.0, 0.7.1, 0.8.0, 0.8.1, 0.8.2, 0.9.0, 0.9.1, 0.9.2, 0.9.3.1)
No matching distribution found for toml==0.9.3

My understanding is that when zappa gets installed, the requirement is toml==0.9.3, but when it tries to make the package that will be send to Amazon, it does not find toml==0.9.3 (it does find toml==0.9.3.1 though).

Would it be a solution to update the requirements.txt (and require toml==0.9.3.1?

My environment is python 3.6, and the latest zappa available in pip.

By the way I think the deployment should fail in this kind of situation. I guess this is what #1235 is about.

@alfonsomhc
Copy link
Author

I tried to install that package version:

$ pip install toml==0.9.3.1
Collecting toml==0.9.3.1
Installing collected packages: toml
  Found existing installation: toml 0.9.3
    Uninstalling toml-0.9.3:
      Successfully uninstalled toml-0.9.3
Successfully installed toml-0.9.3

I checked in pypi (https://pypi.python.org/pypi/toml) and it seems that in fact the two version packages are the same.

Therefore I don't think requirements.txt needs to be udpated. It's probably a bug in the packaging system that doesn't support four levels in the version?

@jwkvam
Copy link
Contributor

jwkvam commented Nov 17, 2017

I think the same issue is causing recent problems in this issue as well #64.

I believe the issue is that the code in toml version 0.9.3.1 refers to itself as 0.9.3 in it's code.

@mcrowson
Copy link
Collaborator

mcrowson commented Dec 4, 2017

Would this be fixed if Zappa didn't peg requirement versions?

@Miserlou
Copy link
Owner

Miserlou commented Dec 4, 2017

This is toml's problem, pinned requirements or not.

@mcrowson
Copy link
Collaborator

mcrowson commented Dec 4, 2017

but it would allow the user to pin the working version of toml and still use the latest/greatest zappa

@tycoles
Copy link

tycoles commented Dec 13, 2017

Yeah it looks like we either roll back to toml 0.9.2 (which may not be possible) or wait for a new toml release (0.9.4). Zappa version 0.44.3 is the latest version of Zappa with working toml (0.9.2) in it, in case anyone out there is wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants