Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsequenceset_make_gaps is not implemented #50

Open
satriabw opened this issue Apr 16, 2024 · 1 comment
Open

tsequenceset_make_gaps is not implemented #50

satriabw opened this issue Apr 16, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@satriabw
Copy link

In MobilityDB 1.1, function ttypeSequenceSetGaps is used to define a gaps in the trajectory dataset and can be useful for data cleaning or defining trajectory. However, the implementation is missing from PyMEOS. Ideally PyMeos implements TSequenceSetGap and call tsequenceset_make_gaps to implement this functionality.

@satriabw satriabw changed the title *tsequenceset_make_gaps* is not implemented tsequenceset_make_gaps is not implemented Apr 16, 2024
@Diviloper Diviloper added good first issue Good for newcomers enhancement New feature or request labels Apr 16, 2024
@Diviloper
Copy link
Member

Indeed, creating TSequenceSets from instants using the gaps functionality is not available in pymeos. Since the function is exposed by the pymeos_cffi library, adding it to pymeos should be straightforward (adding the method to the class and adding the proper tests).
If you are down to make a PR, I'll be more than happy to review it and merge it. Otherwise, I'll try to do it when I have a bit of time.
On the meanwhile though, note that you could still use this functionality, since you can call the pymeos_cffi function with the MEOS instant objects (_inner member of any PyMEOS object) and then passing the result MEOS object to the PyMEOS class constructor (_inner parameter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants