Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace unnecessary Bytes with Vec<u8> and &[u8] in storage module #83

Open
MrCroxx opened this issue Mar 30, 2022 · 2 comments
Open

replace unnecessary Bytes with Vec<u8> and &[u8] in storage module #83

MrCroxx opened this issue Mar 30, 2022 · 2 comments
Assignees
@zackertypical
Labels
enhancement New feature or request for optimization.

Comments

@MrCroxx
Copy link
Owner

MrCroxx commented Mar 30, 2022

As in #74 , create or clone Bytes involves atomic operation, whose costs cannot be ignored if performs frequently (e.g. in iterators). Unnecessary Bytes should be replaced with Vec<u8> or &[u8].
@MrCroxx MrCroxx added the enhancement New feature or request for optimization. label Mar 30, 2022
@zackertypical
Copy link
Contributor

lgtm

@MrCroxx MrCroxx assigned MrCroxx and zackertypical and unassigned MrCroxx Apr 8, 2022
@MrCroxx
Copy link
Owner Author

MrCroxx commented Apr 8, 2022

@zackertypical Welcome, please make sure to run make fmt to lint the codw and resolve all warnings manually, otherwise CI would not pass.

zackertypical added a commit to zackertypical/RunKV that referenced this issue Apr 10, 2022
@zackertypical
fix: replace Bytes with Vec<u8> (MrCroxx#83)
ffb7c1f
zackertypical added a commit to zackertypical/RunKV that referenced this issue Apr 10, 2022
@zackertypical
fix: passed tests (MrCroxx#83)
8135d9d
zackertypical added a commit to zackertypical/RunKV that referenced this issue Apr 10, 2022
@zackertypical
fix: format (MrCroxx#83)
80bb848
zackertypical added a commit to zackertypical/RunKV that referenced this issue Apr 10, 2022
@zackertypical
fix: remove &Vec<u8> (MrCroxx#83)
212f2a3
zackertypical added a commit to zackertypical/RunKV that referenced this issue Apr 10, 2022
@zackertypical
fix: decode function parameter change to &[u8] (MrCroxx#83)
dd34297
@zackertypical zackertypical mentioned this issue Apr 12, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zackertypical zackertypical

Labels
enhancement New feature or request for optimization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrCroxx @zackertypical