Reuse reqwest client across codebase #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
reqwest-cleanup
branch
from
3c3dcd5 to
e88e5e7
Compare
benthecarman
force-pushed
the
reqwest-cleanup
branch
from
e88e5e7 to
701e167
Compare
TonyGiorgio
requested changes
Feb 2, 2024
| @@ -24,7 +24,7 @@ struct CustomClaims { | |||
|
|
|||
| pub struct MutinyAuthClient { | |||
| pub auth: AuthManager, | |||
| lnurl_client: Arc<LnUrlClient>, | |||
| pub lnurl_client: Arc<LnUrlClient>, | |||
There was a problem hiding this comment.
nack
not only should you not be reusing an internal client to MutinyAuth for this, but you should be using an internal client to an internal lnurl client library for this either. either have some generic http client that everyone uses at the top level or let things be as is.
|
Turns out this doesn't matter for wasm, the browser handles it all for you. Will still leave the issue open in case someone wants to pick it up for mutiny-server or whatever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #973
If we create new reqwest clients everywhere we need to create new connections and redo TLS verification for every new client. This makes it so we reuse one across the codebase for pretty much everywhere. Should make things more efficient .
As part of this, moved the bitcoin price code to mutiny wallet instead of the node manager, made more sense here and made the refactor easier.