Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isFirstDownPenalty flag not always accurate #63

Open
BobBrennan opened this issue Feb 7, 2018 · 0 comments
Open

isFirstDownPenalty flag not always accurate #63

BobBrennan opened this issue Feb 7, 2018 · 0 comments
Milestone
Improved Play-by-...

Comments

@BobBrennan
Copy link

BobBrennan commented Feb 7, 2018 •
edited
Loading

NFL Play by play 20180204-NE-MIA

It seems that this flag is not normally set to true when a penalty is accepted that results in a 1st down.

20180114-NO-MIN

5:48 into 1st Quarter: Defensive PassInterference. isFirstDownPenalty shows false
4:52 into 2nd Quarter: Defensive PassInterference. isFirstDownPenalty shows false (Also Defensive Holding but that was declined)
14:39 into 2nd Quarter: Roughing the Passer. isFirstDownPenalty shows false
6:34 into 4th Quarter: Defensive Holding. isFirstDownPenalty shows false
@bradbarkhouse bradbarkhouse added this to the API v2.0 milestone Apr 8, 2018
@bradbarkhouse bradbarkhouse removed this from the API v2.0 milestone Jun 29, 2018
@bradbarkhouse bradbarkhouse added this to the Improved Play-by-Play milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Improved Play-by-Play
Development

No branches or pull requests
2 participants
@bradbarkhouse @BobBrennan