Skip to content

Commit

Permalink
Merge pull request duckdb#87 from carlopi/bump0100
Browse files Browse the repository at this point in the history
Bump to duckdb v0.10.0, re-enable duckdb-wasm
  • Loading branch information
Mytherin authored Feb 21, 2024
2 parents c134346 + 1361648 commit 70a4c41
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 30 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/MainDistributionPipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,19 @@ concurrency:
jobs:
duckdb-stable-build:
name: Build extension binaries
uses: duckdb/duckdb/.github/workflows/_extension_distribution.yml@0e784765f6f87bd1ce9034afcce1e7f89fcd8777
uses: duckdb/duckdb/.github/workflows/_extension_distribution.yml@3fbbd15390059b8028ad6dfd56a3172e5ebc0ab8
with:
vcpkg_commit: a42af01b72c28a8e1d7b48107b33e4f286a55ef6
duckdb_version: 0e784765f6
duckdb_version: v0.10.0
extension_name: sqlite_scanner
exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads'

duckdb-stable-deploy:
name: Deploy extension binaries
needs: duckdb-stable-build
uses: duckdb/duckdb/.github/workflows/_extension_deploy.yml@0e784765f6f87bd1ce9034afcce1e7f89fcd8777
uses: duckdb/duckdb/.github/workflows/_extension_deploy.yml@3fbbd15390059b8028ad6dfd56a3172e5ebc0ab8
secrets: inherit
with:
duckdb_version: 0e784765f6
duckdb_version: v0.10.0
extension_name: sqlite_scanner
exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads'
deploy_latest: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
deploy_versioned: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
56 changes: 33 additions & 23 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,41 @@ ifneq ($(CXX),g++)
endif
endif

OSX_ARCH_FLAG=
#### OSX config
OSX_BUILD_FLAG=
ifneq (${OSX_BUILD_ARCH}, "")
OSX_ARCH_FLAG=-DOSX_BUILD_ARCH=${OSX_BUILD_ARCH}
OSX_BUILD_FLAG=-DOSX_BUILD_ARCH=${OSX_BUILD_ARCH}
endif

ifeq ($(GEN),ninja)
GENERATOR=-G "Ninja"
FORCE_COLOR=-DFORCE_COLORED_OUTPUT=1
#### VCPKG config
VCPKG_TOOLCHAIN_PATH?=
ifneq ("${VCPKG_TOOLCHAIN_PATH}", "")
TOOLCHAIN_FLAGS:=${TOOLCHAIN_FLAGS} -DVCPKG_MANIFEST_DIR='${PROJ_DIR}' -DVCPKG_BUILD=1 -DCMAKE_TOOLCHAIN_FILE='${VCPKG_TOOLCHAIN_PATH}'
endif
ifneq ("${VCPKG_TARGET_TRIPLET}", "")
TOOLCHAIN_FLAGS:=${TOOLCHAIN_FLAGS} -DVCPKG_TARGET_TRIPLET='${VCPKG_TARGET_TRIPLET}'
endif

BUILD_FLAGS=-DEXTENSION_STATIC_BUILD=1 -DBUILD_EXTENSIONS="tpch" ${OSX_ARCH_FLAG} -DDUCKDB_EXPLICIT_PLATFORM='${DUCKDB_PLATFORM}'

CLIENT_FLAGS :=
#### Enable Ninja as generator
ifeq ($(GEN),ninja)
GENERATOR=-G "Ninja" -DFORCE_COLORED_OUTPUT=1
endif

EXT_NAME=sqlite_scanner

#### Configuration for this extension
EXTENSION_FLAGS= \
-DDUCKDB_EXTENSION_NAMES="sqlite_scanner" \
-DDUCKDB_EXTENSION_SQLITE_SCANNER_PATH="$(PROJ_DIR)" \
-DDUCKDB_EXTENSION_SQLITE_SCANNER_SHOULD_LINK=0 \
-DDUCKDB_EXTENSION_SQLITE_SCANNER_LOAD_TESTS=1 \
-DDUCKDB_EXTENSION_SQLITE_SCANNER_TEST_PATH=$(PROJ_DIR)test \
-DDUCKDB_EXTENSION_SQLITE_SCANNER_INCLUDE_PATH="$(PROJ_DIR)src/include" \
EXTENSION_NAME=SQLITE_SCANNER
EXTENSION_FLAGS=\
-DDUCKDB_EXTENSION_NAMES="${EXT_NAME}" \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_PATH="$(PROJ_DIR)" \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_SHOULD_LINK=0 \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_LOAD_TESTS=1 \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_INCLUDE_PATH="$(PROJ_DIR)src/include" \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_TEST_PATH=$(PROJ_DIR)test \

BUILD_FLAGS=-DEXTENSION_STATIC_BUILD=1 -DBUILD_EXTENSIONS="tpch" ${OSX_BUILD_FLAG} -DDUCKDB_EXPLICIT_PLATFORM='${DUCKDB_PLATFORM}'

CLIENT_FLAGS :=
pull:
git submodule init
git submodule update --recursive --remote
Expand Down Expand Up @@ -82,26 +92,26 @@ update:
git submodule update --remote --merge

VCPKG_EMSDK_FLAGS=-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=$(EMSDK)/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake
WASM_COMPILE_TIME_COMMON_FLAGS=-DWASM_LOADABLE_EXTENSIONS=1 -DBUILD_EXTENSIONS_ONLY=1 -DSKIP_EXTENSIONS="parquet" $(VCPKG_EMSDK_FLAGS)
WASM_COMPILE_TIME_COMMON_FLAGS=-DWASM_LOADABLE_EXTENSIONS=1 -DBUILD_EXTENSIONS_ONLY=1 -DSKIP_EXTENSIONS="parquet;json" $(VCPKG_EMSDK_FLAGS) -DDUCKDB_CUSTOM_PLATFORM='${DUCKDB_PLATFORM}' -DDUCKDB_EXPLICIT_PLATFORM='${DUCKDB_PLATFORM}'
WASM_CXX_MVP_FLAGS=
WASM_CXX_EH_FLAGS=$(WASM_CXX_MVP_FLAGS) -fwasm-exceptions -DWEBDB_FAST_EXCEPTIONS=1
WASM_CXX_THREADS_FLAGS=$(WASM_COMPILE_TIME_EH_FLAGS) -DWITH_WASM_THREADS=1 -DWITH_WASM_SIMD=1 -DWITH_WASM_BULK_MEMORY=1
WASM_LINK_TIME_FLAGS=
WASM_LINK_TIME_FLAGS=-O3 -sSIDE_MODULE=2 -sEXPORTED_FUNCTIONS="_${EXT_NAME}_version,_${EXT_NAME}_init"

wasm_mvp:
mkdir -p build/wasm_mvp
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_mvp -DCMAKE_CXX_FLAGS="$(WASM_CXX_MVP_FLAGS) -DDUCKDB_CUSTOM_PLATFORM=wasm_mvp" -S duckdb
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_mvp -DCMAKE_CXX_FLAGS="$(WASM_CXX_MVP_FLAGS)" -S duckdb
emmake make -j8 -Cbuild/wasm_mvp
cd build/wasm_mvp/extension/${EXT_NAME} && emcc $f -sSIDE_MODULE=1 -o ../../${EXT_NAME}.duckdb_extension.wasm -O3 ${EXT_NAME}.duckdb_extension $(WASM_LINK_TIME_FLAGS)
cd build/wasm_mvp/extension/${EXT_NAME} && emcc $f -o ../../${EXT_NAME}.duckdb_extension.wasm ${EXT_NAME}.duckdb_extension.wasm.lib $(WASM_LINK_TIME_FLAGS)

wasm_eh:
mkdir -p build/wasm_eh
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_eh -DCMAKE_CXX_FLAGS="$(WASM_CXX_EH_FLAGS) -DDUCKDB_CUSTOM_PLATFORM=wasm_eh" -S duckdb
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_eh -DCMAKE_CXX_FLAGS="$(WASM_CXX_EH_FLAGS)" -S duckdb
emmake make -j8 -Cbuild/wasm_eh
cd build/wasm_eh/extension/${EXT_NAME} && emcc $f -sSIDE_MODULE=1 -o ../../${EXT_NAME}.duckdb_extension.wasm -O3 ${EXT_NAME}.duckdb_extension $(WASM_LINK_TIME_FLAGS)
cd build/wasm_eh/extension/${EXT_NAME} && emcc $f -o ../../${EXT_NAME}.duckdb_extension.wasm ${EXT_NAME}.duckdb_extension.wasm.lib $(WASM_LINK_TIME_FLAGS)

wasm_threads:
mkdir -p ./build/wasm_threads
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_threads -DCMAKE_CXX_FLAGS="$(WASM_CXX_THREADS_FLAGS) -DDUCKDB_CUSTOM_PLATFORM=wasm_threads" -S duckdb
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_threads -DCMAKE_CXX_FLAGS="$(WASM_CXX_THREADS_FLAGS)" -S duckdb
emmake make -j8 -Cbuild/wasm_threads
cd build/wasm_threads/extension/${EXT_NAME} && emcc $f -sSIDE_MODULE=1 -o ../../${EXT_NAME}.duckdb_extension.wasm -O3 ${EXT_NAME}.duckdb_extension $(WASM_LINK_TIME_FLAGS)
cd build/wasm_threads/extension/${EXT_NAME} && emcc $f -o ../../${EXT_NAME}.duckdb_extension.wasm ${EXT_NAME}.duckdb_extension.wasm.lib $(WASM_LINK_TIME_FLAGS)
2 changes: 1 addition & 1 deletion duckdb
Submodule duckdb updated 70 files
+5 −5 .github/config/extensions.csv
+5 −10 .github/config/out_of_tree_extensions.cmake
+0 −22 .github/patches/extensions/arrow/merged_patch.patch
+0 −85 .github/patches/extensions/postgres_scanner/create_info_refactor.patch
+0 −16 .github/patches/extensions/postgres_scanner/new_attach_param.patch
+0 −69 .github/patches/extensions/postgres_scanner/transaction_rework.patch
+0 −118 .github/patches/extensions/spatial/copy_bind.patch
+0 −116 .github/patches/extensions/sqlite_scanner/combined.patch
+0 −16 .github/patches/extensions/sqlite_scanner/new_attach_param.patch
+0 −19 .github/patches/extensions/substrait/disable_tpch.patch
+0 −18 .github/patches/extensions/substrait/http_state.patch
+0 −54 .github/patches/extensions/substrait/implicit_varchar_cast.patch
+0 −2 .github/workflows/_extension_distribution.yml
+4 −1 README.md
+5,956 −0 data/csv/public_daily_sample.csv
+4 −1 extension/parquet/parquet_extension.cpp
+0 −3 scripts/jdbc_maven_deploy.py
+0 −29 src/common/enum_util.cpp
+1 −1 src/common/local_file_system.cpp
+1 −1 src/common/radix_partitioning.cpp
+1 −1 src/common/row_operations/row_matcher.cpp
+35 −0 src/common/types.cpp
+38 −5 src/common/types/row/tuple_data_collection.cpp
+118 −243 src/common/types/row/tuple_data_scatter_gather.cpp
+0 −8 src/common/types/vector.cpp
+1 −1 src/execution/aggregate_hashtable.cpp
+2 −2 src/execution/join_hashtable.cpp
+3 −3 src/execution/operator/csv_scanner/buffer_manager/csv_buffer.cpp
+1 −1 src/execution/operator/csv_scanner/buffer_manager/csv_buffer_manager.cpp
+27 −17 src/execution/operator/csv_scanner/scanner/string_value_scanner.cpp
+1 −1 src/execution/operator/join/perfect_hash_join_executor.cpp
+26 −30 src/execution/radix_partitioned_hashtable.cpp
+1 −1 src/function/aggregate/sorted_aggregate_function.cpp
+60 −38 src/function/cast/list_casts.cpp
+0 −8 src/include/duckdb/common/enum_util.hpp
+1 −1 src/include/duckdb/common/helper.hpp
+39 −0 src/include/duckdb/common/types.hpp
+7 −14 src/include/duckdb/common/types/row/tuple_data_collection.hpp
+4 −1 src/include/duckdb/common/types/row/tuple_data_states.hpp
+0 −5 src/include/duckdb/common/types/vector.hpp
+1 −1 src/include/duckdb/execution/operator/csv_scanner/buffer_manager/csv_buffer.hpp
+1 −1 src/include/duckdb/execution/operator/csv_scanner/buffer_manager/csv_buffer_manager.hpp
+1 −1 src/include/duckdb/execution/operator/csv_scanner/scanner/base_scanner.hpp
+10 −4 src/include/duckdb/execution/operator/csv_scanner/scanner/string_value_scanner.hpp
+1 −2 src/main/database.cpp
+11 −7 src/main/secret/secret_manager.cpp
+32 −6 src/main/secret/secret_storage.cpp
+1 −2 src/optimizer/statistics/operator/propagate_filter.cpp
+1 −1 src/planner/binder/expression/bind_columnref_expression.cpp
+3 −0 src/storage/buffer/buffer_pool.cpp
+3 −0 src/storage/standard_buffer_manager.cpp
+29 −0 test/fuzzer/duckfuzz/duck_fuzz_column_binding_tests.test
+10 −0 test/helpers/test_helpers.cpp
+2 −0 test/include/test_helpers.hpp
+11 −6 test/optimizer/statistics/statistics_between.test
+8 −0 test/secrets/test_custom_secret_storage.cpp
+16 −0 test/sql/aggregate/aggregates/aggregate_limit.test_slow
+22 −1 test/sql/copy/csv/test_null_padding_projection.test
+6 −0 test/sql/function/timestamp/current_time.test
+45 −0 test/sql/secrets/create_secret_non_writable_persistent_dir.test
+1 −13 test/sql/secrets/create_secret_persistence_error_handling.test
+2 −23 test/sql/secrets/create_secret_scope_matching.test
+8 −25 test/sql/secrets/create_secret_storage_backends.test
+91 −0 test/sql/types/nested/array/array_tupleformat.test
+168 −103 test/sqlite/sqllogic_test_runner.cpp
+6 −0 test/sqlite/sqllogic_test_runner.hpp
+2 −0 test/unittest.cpp
+1 −5 tools/jdbc/src/test/java/org/duckdb/TestDuckDBJDBC.java
+0 −1 tools/juliapkg/Project.toml
+5 −0 tools/pythonpkg/tests/fast/api/test_config.py

0 comments on commit 70a4c41

Please sign in to comment.