Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearance of some buttons (Save, Download, etc.) #28

Open
iG8R opened this issue Oct 31, 2024 · 7 comments
Open

Disappearance of some buttons (Save, Download, etc.) #28

iG8R opened this issue Oct 31, 2024 · 7 comments

Comments

@iG8R
Copy link

iG8R commented Oct 31, 2024

The title speaks for itself.
https://www.youtube.com/watch?v=KehJFetyXHs
image

@jpa102
Copy link

jpa102 commented Nov 30, 2024

youtube has some code somewhere where if there's too many items, it gets hidden in the three dots button

see this comment in issue 1074 in anarios's return youtube dislike extension: Anarios/return-youtube-dislike#1074 (comment) why it behaves like that

@Paprikar
Copy link

Paprikar commented Dec 3, 2024

youtube has some code somewhere where if there's too many items, it gets hidden in the three dots button

see this comment in issue 1074 in anarios's return youtube dislike extension: Anarios/return-youtube-dislike#1074 (comment) why it behaves like that

Theres a mile of space on the page, doesnt really look like an original behavior.

@jpa102
Copy link

jpa102 commented Dec 3, 2024

try resizing the browser window while youtube is running without the extension, you'll see that it gets hidden

@Paprikar
Copy link

Paprikar commented Dec 4, 2024

I just wanna point out that without extension buttons arent getting hidden.
And theres plenty of space in both cases.

Effectively with the extension the like/dislike container behaves like its getting an infinite witdh.

@jpa102
Copy link

jpa102 commented Dec 4, 2024

behaves like its getting an infinite witdh.

yeah, that's why it's causing a "bad loop" in return youtube dislike extension from anarios that they had to make the "extra" buttons hidden

And theres plenty of space in both cases.

let me show you something (using this extension)

image

as you can see in the highlighted element, you'll see that it has a line that makes it "half"

from what i can understand, some youtube code checks if there's more "space" to add a extra action button (in the right area, source comment)

the line looks like that because in the html, the "owner" (channel) and the "actions" (actions toolbar) are put together using display: flex

also a screenshot with anarios's extension enabled:

image

screenshots with zoom percentage set to 50% (this extension and anarios's extension)

image

image

my brain is a little bit fuzzy writing this comment, so this may be wrong

@Paprikar
Copy link

Paprikar commented Dec 4, 2024

my brain is a little bit fuzzy writing this comment, so this may be wrong

TY, now it makes more sense...

btw, sorry for even writing stuff here, i just realized this extension is just different from the "original" one. And i cant see any problems in my case while using this extension, TY!

@jpa102
Copy link

jpa102 commented Dec 4, 2024

that's okay, i've seen people being confused about revanced and revanced extended on reddit (they're mostly talking about youtube)

they're also confused what is vanced and revanced too

and by the way, anarios's return youtube dislike - userscript version doesn't hide the extra buttons unlike the extension version (i have no idea why, i even made a fork of it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants