Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Improve voting options & horizontal scroll #79

Open
2 of 4 tasks
ori-near opened this issue Oct 18, 2024 · 9 comments
Open
2 of 4 tasks

UX: Improve voting options & horizontal scroll #79

ori-near opened this issue Oct 18, 2024 · 9 comments
Assignees
Labels
UX Enabler A UX task that will result in a development task

Comments

@ori-near
Copy link

ori-near commented Oct 18, 2024

Background

Voting options are currently located on the far right side of the pending requests table, making them difficult to find and decreasing voting ease. It is also difficult for users to know that they have a horizontal bar to scroll left and right within table.

Image

UX Need

Need to update the Pending Requests table with a more prominent and clearly visible voting option. This will make it easier for users with voting permissions to take immediate action. Also need to make it easier for users to know that they can scroll left and right in the horizontal table.

Acceptance Criteria

  • Create a mockup showing what the updated table should look like to make the voting column easier (e.g. moving approve/reject buttons to the left?)
  • Update the development ticket (Improve visibility of voting options in pending requests table #74) with the solution and move from Blocked Status to Backlog
  • Create a mockup showing what the updated table should look like to make it more obvious that the user can scroll left and right within the table.
  • Create development ticket (with Ori) to improve horizontal scrolling
@ori-near ori-near changed the title UX: Improve voting options Add "Refresh" button Oct 22, 2024
@ori-near ori-near changed the title Add "Refresh" button UX: Improve voting options Oct 22, 2024
@ori-near ori-near moved this from 🆕 Triage to 📋 Backlog in 🚀 DevHub Products Oct 22, 2024
@ori-near ori-near added the UX Enabler A UX task that will result in a development task label Oct 22, 2024
@FREZZZBE
Copy link
Collaborator

FREZZZBE commented Oct 22, 2024

Solution

  1. Open table settings
  2. Hover selected option
  3. Click Pin icont to pin> Lets pin voting column by default

We make an option to pin any column from left or rite side of the table

Treasury.Pin.column.flow.mp4

@ori-near ori-near changed the title UX: Improve voting options UX: Improve voting options & horizontal scroll Oct 22, 2024
@ori-near
Copy link
Author

Solution

  1. Open table settings
  2. Hover selected option
  3. Click Pin icont to pin> Lets pin voting column by default

We make an option to pin any column from left or rite side of the table

Treasury.Pin.column.flow.mp4

Hey @FREZZZBE – I like this direction for sure. A couple of quick reactions:

  • Right now the pin button doesn't seem visible unless you hover over the table. Could we always show it but make it light/transparent ish similar to the eye button when not selected?
  • Are we only making the option to pin votes? Or any other columns? If the latter, can you show that would look when you select multiple random ones? Will they always show on the right?

@FREZZZBE
Copy link
Collaborator

FREZZZBE commented Oct 22, 2024

Hey @FREZZZBE – I like this direction for sure. A couple of quick reactions:

  • Right now the pin button doesn't seem visible unless you hover over the table. Could we always show it but make it light/transparent ish similar to the eye button when not selected?
  • Are we only making the option to pin votes? Or any other columns? If the latter, can you show that would look when you select multiple random ones? Will they always show on the right?

Hey @ori-near

  • Yes we can.Just trying to make it more clean but it doesn't cost this risk you right.
  • I think we can make it only for votes for now. or we can make it for all but it probably will be 5x more complex for dev.
  • We can make this logich: if you pin smthing from red zone - it will stick to left. From yellow to right.
  • We can limit pined colums by viewport size or by specific amount e.g. 5 in total
  • Image Image

@ori-near
Copy link
Author

@FREZZZBE – agree that we don't need to overcomplicate. Let's get input from @Megha-Dev-19 and the other devs to see what would be the easiest path.

@FREZZZBE
Copy link
Collaborator

@ori-near are we ready to mark as done?

@Megha-Dev-19
Copy link
Collaborator

hey, sorry I missed my mention, I like the pinned solution, but it will be pretty complicated to add it for all columns, so maybe we can only do it for votes now, and I think it's better if it's enabled by default, since first time voters should definitely see their vote option, and they can turn it off if needed.

@FREZZZBE
Copy link
Collaborator

hey, sorry I missed my mention, I like the pinned solution, but it will be pretty complicated to add it for all columns, so maybe we can only do it for votes now, and I think it's better if it's enabled by default, since first time voters should definitely see their vote option, and they can turn it off if needed.

Agree with this solution. @ori-near could you update following task if you are agree with this too?

@ori-near
Copy link
Author

Hi @FREZZZBE @Megha-Dev-19 – thank you for you feedback. I went ahead and updated the development ticket for the voting column and removed the dependency on this ticket: #74

A couple of follow ups:

  1. @Megha-Dev-19 I think we named the "Votes" column "Actions" – because actions might vary based on the user. But should we relabel them "Votes"? OR will that cause an issue?
  2. @FREZZZBE Can you please work on the second part of this ticket (horizontal scroll)? I updated the AC.

@ori-near ori-near moved this from ❌ Blocked to 🏗 In progress in 🚀 DevHub Products Oct 28, 2024
@FREZZZBE
Copy link
Collaborator

Can you please work on the second part of this ticket (horizontal scroll)? I updated the AC.

@ori-near fill like it's overrated problem. A lot of tools have tables and when it's too wide it's use common horisontal scroll. I would like to test it with just pined vots. Pined votes must more visual indicate that.

@FREZZZBE FREZZZBE moved this from 🏗 In progress to ❌ Blocked in 🚀 DevHub Products Oct 30, 2024
@ori-near ori-near moved this from ❌ Blocked to ✅ Done in 🚀 DevHub Products Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Enabler A UX task that will result in a development task
Projects
Status: Done
Development

No branches or pull requests

3 participants