Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

146 comply with dalia csv format #600

Closed
wants to merge 9 commits into from

Conversation

lea-33
Copy link
Collaborator

@lea-33 lea-33 commented Jan 24, 2025

Related to #146 and #142

@lea-33 lea-33 linked an issue Jan 24, 2025 that may be closed by this pull request
@lea-33
Copy link
Collaborator Author

lea-33 commented Jan 24, 2025

the export needed 5min (!!), not sure if we should not rather switch to only exporting the csv if the yml has changed @haesleinhuepf ?
I guess it takes quite long to run the model for the language detection and also to look for the file formats for every zenodo link (at least those were the two tasks that seemed to take quite long when I was testing the notebook).

@lea-33
Copy link
Collaborator Author

lea-33 commented Jan 24, 2025

Also I'm a little bit confused because I can't find the .csv file. Is it only there AFTER the branch got merged or should it be appear in the docs/export folder already?

@lea-33
Copy link
Collaborator Author

lea-33 commented Jan 29, 2025

git-bob comment if you have an idea how one could fix this issue. The csv is only created on the virtual machine running the actions and not implemented in our repository. how do we have to modify the test.yml from the workflows to ensure that the newly created .csv file is included in the repository?

@lea-33 lea-33 closed this Jan 29, 2025
@lea-33
Copy link
Collaborator Author

lea-33 commented Jan 29, 2025

see #608 instead

@lea-33 lea-33 deleted the 146-comply-with-dalia-csv-format branch January 31, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comply with DALIA CSV format
1 participant