Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reactions as children of rxno:addition #3

Open
StroemPhi opened this issue Apr 20, 2021 · 3 comments
Open

add reactions as children of rxno:addition #3

StroemPhi opened this issue Apr 20, 2021 · 3 comments

Comments

@StroemPhi
Copy link
Member

StroemPhi commented Apr 20, 2021

We have identified the following five reactions to be children of the rxno:addition class:

  • Thiol-yne
  • Mukaiyama hydration
  • Favorskii reaction
  • Diimide reduction
  • acetalization

These will be added to the branch add-reactions-as-children-of-rxnoaddition to be merged into the upstream repository later.

StroemPhi added a commit that referenced this issue Apr 20, 2021
We needed to copy "addition reaction" from MOP to RXNO before being able to add children to that class.
@StroemPhi
Copy link
Member Author

We needed to copy "addition reaction" from MOP to RXNO before being able to add children to that class in 082b7e2

StroemPhi added a commit that referenced this issue Apr 20, 2021
@StroemPhi
Copy link
Member Author

StroemPhi commented Apr 20, 2021

As we forgot to also import the children of MOP_0000642, but more importantly, as it is better to directly import the whole MOP, we did so in dd66397.
We think the direct import of MOP is better than the previous manual imports of MOP terms into RXNO, as MOP provides the general terms that are needed in RXNO.

@hujo91
Copy link
Collaborator

hujo91 commented Apr 20, 2021

#4 adresses the problem of confusion between MOP:0000629 & RXNO:0000246

StroemPhi added a commit that referenced this issue Apr 21, 2021
we need to revert this commit because of the follow up problems identified in issue #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants