Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 branch #118

Open
ceuk opened this issue May 19, 2022 · 3 comments
Open

V1 branch #118

ceuk opened this issue May 19, 2022 · 3 comments

Comments

@ceuk
Copy link

ceuk commented May 19, 2022

Hi, would it be possible to create a dedicated branch for v1.x? There are a couple of small v1 bugs we'd like to create PRs for ideally. (We are unable to upgrade to v2 currently until we get sign-off).
@kevinkuszyk
Copy link
Contributor

kevinkuszyk commented May 19, 2022 •
edited
Loading

Hi @ceuk

I just cut a release/v1.x branch. Feel free to target your PRs there.

Are we tracking issues yet for the fixes you have planned?

And finally advance warning - you may have to bear with me when it comes to publishing a new 1.x to npm - I'll have to do that manually as we did't have the CD setup until we were closer to 2.x.

@Kyutel
Copy link

Kyutel commented May 19, 2022 •
edited
Loading

Its basically this one #69
and related to that is an incorrect type that you have fixed in this commit c45d5c5

@edwardhorsford
Copy link
Contributor

@ceuk is this issue still relevant? if not do you mind if we close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ceuk @edwardhorsford @kevinkuszyk @Kyutel