diff --git a/documentation/reference_doc/4_5_envelope.tex b/documentation/reference_doc/4_5_envelope.tex
index d9f5f6a6d..1f7d595ba 100644
--- a/documentation/reference_doc/4_5_envelope.tex
+++ b/documentation/reference_doc/4_5_envelope.tex
@@ -19,7 +19,7 @@ \subsection{Walls} % Andrew
\paragraph{Wall System Turnover Rate}
As described in Section~\ref{sec:system_turnover_and_eul}, we assume that some building systems, including exterior walls, are replaced over the lifespan of the building. Typically, for exterior walls, the structural elements of the wall are maintained, while the cladding, insulation, sheathing, etc. are be replaced. As noted in Section~\ref{sec:system_turnover_and_eul}, the EUL for exterior walls is assumed to be 200 years, which means that most buildings are modeled with the walls they were built with. Once the wall construction type probabilities and distributions of building types, sizes, and vintages are carried through the sampling process and simulations are created, the distribution of construction types and energy code levels can be reviewed. As shown in Figure~\ref{fig:weighted_floor_area_by_energy_code_and_wall_type}, because the majority of the building stock is older, and wall systems are replaced at a low rate, most of the building floor area is assumed to have walls that follow the oldest energy codes.
-\begin{figure}[ht!] \centering
+\begin{figure}[ht!] \centering
\includegraphics[
page={1},
trim={1cm 18.3cm 1cm 1cm}, clip, % L B R T
@@ -46,7 +46,7 @@ \subsection{Walls} % Andrew
\subsection{Windows} % Andrew
\paragraph{Window Construction Type}
-Data from the NFRC Commercial Fenestration Market Study was used to develop the modeling approach for windows in ComStock. This study, conducted by Guidehouse in collaboration with NFRC, characterized the national commercial window stock through data collection and analysis. Six primary data sources representing all regions of the United States were used in the study---a 2020 Guidehouse survey, NEEA CBSA, DOE Code Study, CAEUS, CBECS, and RECS. A variety of window properties were collected, including the window-to-wall ratio, number of panes, frame material, glazing type, low-E coating, gas fill, solar heat gain coefficient (SHGC), U-factor, and many others. In total, the database contained approximately 16,000 samples, each with an appropriate weighting factor based on the coverage, completeness, and fidelity of each data source. The WWR data was already incorporated into the ComStock baseline during the EULP project. Some of the other key window properties such as thermal performance were then used to create the new baseline window constructions and distributions discussed later in this section. A summary of the data sources and their associated information is shown in Table ~\ref{tab:window_data_sources}.
+Data from the NFRC Commercial Fenestration Market Study was used to develop the modeling approach for windows in ComStock. This study, conducted by Guidehouse in collaboration with NFRC, characterized the national commercial window stock through data collection and analysis. Six primary data sources representing all regions of the United States were used in the study---a 2020 Guidehouse survey, NEEA CBSA, DOE Code Study, CAEUS, CBECS, and RECS. A variety of window properties were collected, including the window-to-wall ratio, number of panes, frame material, glazing type, low-E coating, gas fill, solar heat gain coefficient (SHGC), U-factor, and many others. In total, the database contained approximately 16,000 samples, each with an appropriate weighting factor based on the coverage, completeness, and fidelity of each data source. The WWR data was already incorporated into the ComStock baseline during the EULP project. Some of the other key window properties such as thermal performance were then used to create the new baseline window constructions and distributions discussed later in this section. A summary of the data sources and their associated information is shown in Table ~\ref{tab:window_data_sources}.
Four window properties---number of panes, glazing type, frame material, and low-E coating---were used to create the baseline window configurations. These four parameters were selected based on which characteristics have the most impact on window performance, which have the most data available from the various data sources, and which inputs we trust from the average building owner or survey recipient. The options for each property are shown in Figure \ref{fig:window_configurations}.
@@ -59,38 +59,38 @@ \subsection{Windows} % Andrew
\end{figure}
\vspace{5mm}
-Modeling every combination of these four properties would result in 36 different window configurations, which would add significant complexity to the sampling process. Instead, we selected 12 combinations to be modeled, based on which combinations are most common and most realistic. There are four single-pane, six double-pane, and two triple-pane configurations. The unrealistic/uncommon combinations that were eliminated include:
+Modeling every combination of these four properties would result in 36 different window configurations, which would add significant complexity to the sampling process. Instead, we selected 12 combinations to be modeled, based on which combinations are most common and most realistic. There are four single-pane, six double-pane, and two triple-pane configurations. The unrealistic/uncommon combinations that were eliminated include:
\begin{itemize}
-\item Single pane with thermally broken aluminum frame
-\item Single pane with low-E coating
-\item Double pane with wood frame
-\item Triple pane with no low-E coating
-\item Triple pane without thermally broken aluminum frame
-\item Thermally broken double or triple pane without low-E coating.
+\item Single pane with thermally broken aluminum frame
+\item Single pane with low-E coating
+\item Double pane with wood frame
+\item Triple pane with no low-E coating
+\item Triple pane without thermally broken aluminum frame
+\item Thermally broken double or triple pane without low-E coating.
\end{itemize}
The 12 remaining window configurations are shown in Table \ref{tab:window_configurations}.
\input{tables/window_configurations}
-We created a sampling distribution for the new window constructions for the entire country using the initial data set. Overall, single-pane windows make up approximately 54\% of the stock, double-pane windows make up 46\%, and triple-pane windows make up <1\%. Initially, we created distributions based on census division to incorporate geographic location into the sampling. Upon further analysis, we found that it was also necessary to incorporate the energy codes into distributions to prevent scenarios where a single-pane window was sampled for a certain location, but, according to the energy code for that location, a double-pane window was required. For this reason, we modified the sampling distribution to include two dependencies---climate\_zone and energy\_code\_followed\_during\_last\_window\_replacement.
+We created a sampling distribution for the new window constructions for the entire country using the initial data set. Overall, single-pane windows make up approximately 54\% of the stock, double-pane windows make up 46\%, and triple-pane windows make up <1\%. Initially, we created distributions based on census division to incorporate geographic location into the sampling. Upon further analysis, we found that it was also necessary to incorporate the energy codes into distributions to prevent scenarios where a single-pane window was sampled for a certain location, but, according to the energy code for that location, a double-pane window was required. For this reason, we modified the sampling distribution to include two dependencies---climate\_zone and energy\_code\_followed\_during\_last\_window\_replacement.
-To generate these sampling distributions, we used the maximum U-values specified for each climate zone in each version of ASHRAE 90.1, using climate zones defined by ASHRAE 169--2006. For each combination of climate zone and energy code, the 12 window configurations were evaluated to determine which were both realistic and met code (i.e., had a U-value lower than the code maximum U-value). For the older energy codes, we made several assumptions about technology adoption to determine which window configurations were realistic:
+To generate these sampling distributions, we used the maximum U-values specified for each climate zone in each version of ASHRAE 90.1, using climate zones defined by ASHRAE 169--2006. For each combination of climate zone and energy code, the 12 window configurations were evaluated to determine which were both realistic and met code (i.e., had a U-value lower than the code maximum U-value). For the older energy codes, we made several assumptions about technology adoption to determine which window configurations were realistic:
\begin{itemize}
- \item Low-E coating---not adopted until DOE Ref 1980--2004
- \item Thermally broken aluminum frame---not adopted until 90.1-2004
- \item Triple pane---not adopted until 90.1-2004.
+ \item Low-E coating---not adopted until DOE Ref 1980--2004
+ \item Thermally broken aluminum frame---not adopted until 90.1-2004
+ \item Triple pane---not adopted until 90.1-2004.
\end{itemize}
-Each combination of climate zone and energy code included 2--12 window configurations that met the criteria. After limiting the distributions to these configurations, we renormalized the percentages from the national distribution to 100\%. This kept the percentages from the national distribution while also incorporating intelligent assumptions based on climate zone and energy code. Table ~\ref{tab:window_distribution_4A} provides an example of the window configurations that were sampled for each code year in climate zone 4A.
+Each combination of climate zone and energy code included 2--12 window configurations that met the criteria. After limiting the distributions to these configurations, we renormalized the percentages from the national distribution to 100\%. This kept the percentages from the national distribution while also incorporating intelligent assumptions based on climate zone and energy code. Table ~\ref{tab:window_distribution_4A} provides an example of the window configurations that were sampled for each code year in climate zone 4A.
\input{tables/window_distribution_4A}
-As can be seen in Table \ref{tab:window_distribution_4A}, for DOE Ref Pre-1980, the only windows that met code and are realistic are single-pane or double-pane windows with no low-E coating. For DOE Ref 1980--2004, the maximum U-value dropped significantly, such that single-pane aluminum windows no longer met code. However, double-pane low-E windows became available on the market at that time. For 90.1-2004 through 90.1-2010, code required a U-value equivalent to double-pane low-E or better, and in 90.1-2013, the code improved again, meaning that double-pane low-E with a thermal break or better was required. This type of logic was applied to all combinations of climate zone and energy code. Then, we converted the data into the distributions used in sampling.
+As can be seen in Table \ref{tab:window_distribution_4A}, for DOE Ref Pre-1980, the only windows that met code and are realistic are single-pane or double-pane windows with no low-E coating. For DOE Ref 1980--2004, the maximum U-value dropped significantly, such that single-pane aluminum windows no longer met code. However, double-pane low-E windows became available on the market at that time. For 90.1-2004 through 90.1-2010, code required a U-value equivalent to double-pane low-E or better, and in 90.1-2013, the code improved again, meaning that double-pane low-E with a thermal break or better was required. This type of logic was applied to all combinations of climate zone and energy code. Then, we converted the data into the distributions used in sampling.
-A small adjustment was made to the final distributions because some states and localities do not follow or enforce energy codes strictly. Following the code exactly would likely overestimate window performance. Therefore, in scenarios where single-pane windows were technically below code, we assumed that 5\% of all windows in the stock would still have the worst-performing single-pane windows installed. The distributions were adjusted accordingly by subtracting 5\% total from the double-pane configurations and adding to the single-pane aluminum configurations. After making this manual adjustment, the new distributions had the same overall breakdown as the national distribution generated from the Guidehouse data---54\% single-pane and 46\% double-pane .
+A small adjustment was made to the final distributions because some states and localities do not follow or enforce energy codes strictly. Following the code exactly would likely overestimate window performance. Therefore, in scenarios where single-pane windows were technically below code, we assumed that 5\% of all windows in the stock would still have the worst-performing single-pane windows installed. The distributions were adjusted accordingly by subtracting 5\% total from the double-pane configurations and adding to the single-pane aluminum configurations. After making this manual adjustment, the new distributions had the same overall breakdown as the national distribution generated from the Guidehouse data---54\% single-pane and 46\% double-pane .
\paragraph{Window Thermal Performance}
-Once the 12 new window constructions were determined, a team from Lawrence Berkeley National Laboratory's (LBNL’s) Windows and Daylighting Group used the WINDOW program to assign thermal performance properties to each construction. SimpleGlazing objects in EnergyPlus were chosen to represent windows to reduce complexity. This choice also simplifies the process of applying upgrades, because all fenestration objects in the baseline models use the same object type. The inputs for the SimpleGlazing object are U-factor, solar heat gain coefficient (SHGC), and visible light transmittance (VLT). For each window configuration, LBNL assigned a frame ID and window ID from the WINDOW database. They also filled in the respective U-factors, SHGCs, and VLTs, which are shown in Table \ref{tab:window_thermal_performance}.
+Once the 12 new window constructions were determined, a team from Lawrence Berkeley National Laboratory's (LBNL’s) Windows and Daylighting Group used the WINDOW program to assign thermal performance properties to each construction. SimpleGlazing objects in EnergyPlus were chosen to represent windows to reduce complexity. This choice also simplifies the process of applying upgrades, because all fenestration objects in the baseline models use the same object type. The inputs for the SimpleGlazing object are U-factor, solar heat gain coefficient (SHGC), and visible light transmittance (VLT). For each window configuration, LBNL assigned a frame ID and window ID from the WINDOW database. They also filled in the respective U-factors, SHGCs, and VLTs, which are shown in Table \ref{tab:window_thermal_performance}.
The U-factors originally ranged from U-1.18 Btu/h·ft\textsuperscript{2}·F for the worst-performing single-pane window to U-0.30 Btu/h·ft\textsuperscript{2}·F for the best-performing triple-pane window. As mentioned earlier in this section, the maximum U-Factor that EnergyPlus can model with a simple glazing object is U-1.02 Btu/h·ft\textsuperscript{2}·F, which is governed by the limitations of a 2D heat transfer model when interior and exterior air films are included. Therefore, we adjusted the U-factor for the first two single-pane windows to be U-1.02 Btu/h·ft\textsuperscript{2}·F rather than U-1.18 Btu/h·ft\textsuperscript{2}·F. This allowed these windows to be modeled in ComStock. This results in a slight overestimate of the thermal performance of single-pane windows.
@@ -122,7 +122,7 @@ \subsection{Roof} % Andrew
\paragraph{Roof System Turnover Rate}
As described in Section \ref{sec:system_turnover_and_eul}, some building systems, including roofs, are assumed to be replaced over the lifespan of the building. Typically, for roofs, the structural elements are maintained, while the roof membrane and insulation are replaced. As noted in Section \ref{sec:system_turnover_and_eul}, the EUL for roofs was assumed to be 200 years, which means that most buildings are modeled with the roof insulation they were built with. Once the roof type probabilities and distribution of building types, sizes, and vintages are carried through the sampling process and simulations are created, the distribution of energy code levels can be reviewed. As shown in Figure~\ref{fig:weighted_floor_area_by_energy_code_roofs}, because the majority of the building stock is older, and roof systems are replaced at a low rate, most of the building floor area is assumed to have roofs that follow the oldest energy codes.
-\begin{figure}[h] \centering
+\begin{figure}[h] \centering
\includegraphics[
page={3},
trim={1cm 20.5cm 1cm 1cm}, clip, % L B R T
@@ -143,8 +143,12 @@ \subsection{Floor}
\paragraph{Floor Thermal Performance}
We did not find any data sources that contained the thermal performance of floors in the commercial building stock. This is likely because surveys would need to either find building plans, which can be difficult or impossible for older buildings, or excavate under a slab edge, which is impractical. To account for the lack of data, we estimated floor thermal performance based on an estimate of the energy code followed when building was first constructed. Section~\ref{sec:energy_code} describes how the energy code was determined. The thermal performance of floors for each energy code varies based on climate zone, as shown in Table~\ref{tab:floor_f_factors}. It is notable that only buildings built to the newest energy codes in the coldest climates assume any sort of slab insulation.
+\subsection{Thermal Bridging} % Matthew Dahlhausen
+Thermal bridging includes the impact of uninsulated structural elements that undermine the overall thermal resistance of an opaque assembly. These include linear thermal bridges, such as along corners, roof parapets, and fenestration, and point thermal bridges, such as protruding steel beams. These are formalized by psi factors multiplied by the length of a thermal bridge, and chi factors multiplied by the number of a thermal bridge. ASHRAE publishes psi and chi factors for common major thermal bridges, and thermal bridging requirements were recently added to the envelope section of ASHRAE 90.1-2022 \citep{ashrae_901_2022}. See Appendix section A10.2 of ASHRAE 90.1-2022 for details on calculating thermal bridges.
+
+Thermal bridging in ComStock is implemented with the Thermal Bridging and Derating (TBD) ruby gem \citep{tbd_gem}. The gem detects the presence of common major thermal bridges in the model (corners, parapets, etc.), and derates the adjacent opaque surface construction (walls and roofs) to account for the thermal bridging. TBD gem version 3.4.1 includes default ASHRAE 90.1-2022 psi and chi factors for different kinds of thermal bridges. These vary by wall construction type (steel frame, mass, wood) and whether thermal bridges are considered mitigated or unmitigated. By default, ComStock assumed the unmitigated 90.1-2022 psi and chi factors by wall construction type. Specific values are listed in the TBD gem \citep{tbd_gem}.
-\subsection{Infiltration and Natural Ventilation}
+\subsection{Infiltration and Natural Ventilation} % Matthew Dahlhausen
\subsubsection{Infiltration}
Infiltration in ComStock uses the same model as EnergyPlus \citep{energy_plus}, detailed in equation \ref{energyplus_infiltration_eqn}.
diff --git a/documentation/reference_doc/bibliography.bib b/documentation/reference_doc/bibliography.bib
index 378ced561..c8e1c631d 100644
--- a/documentation/reference_doc/bibliography.bib
+++ b/documentation/reference_doc/bibliography.bib
@@ -22,6 +22,13 @@ @techreport{ashrae_901_2010
year = 2010
}
+@techreport{ashrae_901_2022,
+ title = {Standard 90.1-2022 (I-P Edition) Energy Standard for Buildings Except Low-Rise Residential Buildings},
+ author = {ASHRAE},
+ institution = {ASHRAE},
+ year = 2022
+}
+
@misc{egrid2020,
title = {Emissions and Generation Resource Integrated Database (eGRID), 2020},
author = {{U.S. Environmental Protection Agency (EPA)}},
@@ -583,6 +590,13 @@ @misc{trane_foundation
year = 2023,
}
+@misc{tbd_gem,
+ title = {Thermal Bridging and Derating, Version 3.4.2},
+ author = {Denis Bourgeois and Dan Macumber},
+ url = {https://github.com/rd2/tbd},
+ year = 2024,
+}
+
@misc{carrier_economiser,
title = {Carrier Economizer},
author = {{Carrier}},
diff --git a/national/housing_characteristics/options_lookup.tsv b/national/housing_characteristics/options_lookup.tsv
index 9a731b538..8f6572054 100644
--- a/national/housing_characteristics/options_lookup.tsv
+++ b/national/housing_characteristics/options_lookup.tsv
@@ -4638,6 +4638,15 @@ baseline_window_type Single - No LowE - Tinted/Reflective - Aluminum replace_bas
baseline_window_type Single - No LowE - Tinted/Reflective - Wood replace_baseline_windows window_pane_type=Single - No LowE - Tinted/Reflective - Wood u_value_ip=0.91 shgc=0.525 vlt=0.436
baseline_window_type Triple - LowE - Clear - Thermally Broken Aluminum replace_baseline_windows window_pane_type=Triple - LowE - Clear - Thermally Broken Aluminum u_value_ip=0.3 shgc=0.328 vlt=0.527
baseline_window_type Triple - LowE - Tinted/Reflective - Thermally Broken Aluminum replace_baseline_windows window_pane_type=Triple - LowE - Tinted/Reflective - Thermally Broken Aluminum u_value_ip=0.299 shgc=0.224 vlt=0.32
+thermal_bridging steel-framed and metal default thermal_bridging_derating option=90.1.22|steel.m|default
+thermal_bridging steel-framed and metal unmitigated thermal_bridging_derating option=90.1.22|steel.m|unmitigated
+thermal_bridging mass default thermal_bridging_derating option=90.1.22|mass.ex|default
+thermal_bridging mass unmitigated thermal_bridging_derating option=90.1.22|mass.ex|unmitigated
+thermal_bridging interior mass default thermal_bridging_derating option=90.1.22|mass.in|default
+thermal_bridging interior mass unmitigated thermal_bridging_derating option=90.1.22|mass.in|unmitigated
+thermal_bridging wood-framed default thermal_bridging_derating option=90.1.22|wood.fr|default
+thermal_bridging wood-framed unmitigated thermal_bridging_derating option=90.1.22|wood.fr|unmitigated
+thermal_bridging no thermal bridging thermal_bridging_derating option=(non thermal bridging)
baseline_hvac_sizing autosize hardsize_model apply_hardsize=false
baseline_hvac_sizing hardsize hardsize_model apply_hardsize=true
occupancy_schedule_adjust adjust_schedule adjust_occupancy_schedule peak_occ_frac=0.231
diff --git a/resources/measures/README.md b/resources/measures/README.md
index 61d36d775..6809e55ad 100644
--- a/resources/measures/README.md
+++ b/resources/measures/README.md
@@ -55,6 +55,7 @@ Measures are added to the workflow in order they first appear in the [`options_l
| add_thermostat_setpoint_variability | Modifies the heating and cooling setpoints and setbacks/setups. |
| set_primary_kitchen_equipment | Replaces kitchen equiment with discrete equipment assumptions |
| replace_baseline_windows | Replaces windows in model (originally based on code) with windows of a specific technology type (single-pane, double-pane, etc.) |
+| thermal_bridging_derating | Derates opaque constructions thermal resistance to account for thermal bridging |
| adjust_occupancy_schedule | Reduced the values of all occupancy schedules in the model by a specified percentage |
| hardsize_model | Do a sizing run, which populates the SQL file with the EnergyPlus-calculated capacities and flows |
| | Hard-size HVAC and SWH equipment in the model based on EnergyPlus-calculated capacities and flows. No model changes from here forward will be reflected in the sizing of HVAC equipment unless done intentionally as part of an upgrade. |
diff --git a/resources/measures/set_roof_template/measure.rb b/resources/measures/set_roof_template/measure.rb
index 9c3bd8e44..b5202db9f 100644
--- a/resources/measures/set_roof_template/measure.rb
+++ b/resources/measures/set_roof_template/measure.rb
@@ -185,8 +185,8 @@ def run(model, runner, user_arguments)
# set additional properties for building
props = model.getBuilding.additionalProperties
- props.setFeature('roof_as_constructed_template', as_constructed_template)
- props.setFeature('roof_template', template)
+ props.setFeature('roof_as_constructed_template',"#{as_constructed_template}")
+ props.setFeature('roof_template',"#{template}")
# Not applicable if the selected template matches the as-constructed template
if template == as_constructed_template
@@ -196,51 +196,60 @@ def run(model, runner, user_arguments)
# Make a standard
reset_log
- standard = Standard.build(template)
-
- # Apply standard constructions to this model at the surface-by-surface level,
- # which will override default contruction sets for the surface types being updated,
- # which is not all surface types.
- types_to_modify = []
- types_to_modify << ['Outdoors', 'RoofCeiling']
-
- # Find just those surfaces
- surfaces_to_modify = []
- types_to_modify.each do |boundary_condition, surface_type|
- # Surfaces
- model.getSurfaces.sort.each do |surf|
- next unless surf.outsideBoundaryCondition == boundary_condition
- next unless surf.surfaceType == surface_type
-
- surfaces_to_modify << surf
- end
-
- # SubSurfaces
- model.getSubSurfaces.sort.each do |surf|
- next unless surf.outsideBoundaryCondition == boundary_condition
- next unless surf.subSurfaceType == surface_type
-
- surfaces_to_modify << surf
- end
+ standard = Standard.build("#{template}")
+
+ # Check that a default construction set is defined
+ bldg_def_const_set = model.getBuilding.defaultConstructionSet
+ unless bldg_def_const_set.is_initialized
+ runner.registerError('Model does not have a default construction set.')
+ return false
end
+ bldg_def_const_set = bldg_def_const_set.get
- # Modify these surfaces
- prev_created_consts = {}
- surfaces_to_modify.sort.each do |surf|
- prev_created_consts = standard.planar_surface_apply_standard_construction(surf, climate_zone, prev_created_consts)
+ # Check that a default exterior construction set is defined
+ ext_surf_consts = bldg_def_const_set.defaultExteriorSurfaceConstructions
+ unless ext_surf_consts.is_initialized
+ runner.registerError("Default construction set '#{bldg_def_const_set.name}' has no default exterior surface constructions.")
+ return false
end
+ ext_surf_consts = ext_surf_consts.get
- # List the unique array of constructions
- prev_created_consts.each do |surf_type, construction|
- runner.registerInfo("For #{surf_type.join(' ')}, applied #{construction.name}.")
+ # Check that a default exterior roof is defined
+ unless ext_surf_consts.roofCeilingConstruction.is_initialized
+ runner.registerError("Default surface construction set #{ext_surf_consts.name} has no default exterior roof construction.")
+ return false
end
+ old_construction = ext_surf_consts.roofCeilingConstruction.get
+ standards_info = old_construction.standardsInformation
- log_messages_to_runner(runner, debug = false)
- reset_log
+ # Get the old roof construction type
+ if standards_info.standardsConstructionType.empty?
+ old_roof_construction_type = 'Not defined'
+ else
+ old_roof_construction_type = standards_info.standardsConstructionType.get
+ end
- if prev_created_consts.empty?
- runner.registerAsNotApplicable("Found no #{surf_type.join(' ')} surfaces in the model to update")
+ # Get the building occupancy type
+ if model.getBuilding.standardsBuildingType.is_initialized
+ model_building_type = model.getBuilding.standardsBuildingType.get
+ else
+ model_building_type = ''
+ end
+ if ['SmallHotel', 'LargeHotel', 'MidriseApartment', 'HighriseApartment'].include?(model_building_type)
+ occ_type = 'Residential'
+ else
+ occ_type = 'Nonresidential'
end
+ climate_zone_set = standard.model_find_climate_zone_set(model, climate_zone)
+ new_construction = standard.model_find_and_add_construction(model,
+ climate_zone_set,
+ 'ExteriorRoof',
+ old_roof_construction_type,
+ occ_type)
+ ext_surf_consts.setRoofCeilingConstruction(new_construction)
+
+ log_messages_to_runner(runner, debug = false)
+ reset_log
return true
end
diff --git a/resources/measures/set_roof_template/measure.xml b/resources/measures/set_roof_template/measure.xml
index bbb5bf576..3a8f7d639 100644
--- a/resources/measures/set_roof_template/measure.xml
+++ b/resources/measures/set_roof_template/measure.xml
@@ -3,8 +3,8 @@
3.1
set_roof_template
0b13c46d-123f-4d6c-b5d8-65a23acf1141
- 02a7bc2c-8b27-4b68-a198-6026178c47ea
- 2024-10-16T23:19:32Z
+ c8d81d59-6a62-4748-9ae8-5d9554636872
+ 2024-11-12T20:38:31Z
66CE07BA
SetRoofTemplate
Set Roof Template
@@ -530,7 +530,7 @@
measure.rb
rb
script
- A1DAFAF1
+ F5D033A6
set_roof_template_test.rb
diff --git a/resources/measures/set_wall_template/measure.rb b/resources/measures/set_wall_template/measure.rb
index dc0bd060d..e313cc191 100644
--- a/resources/measures/set_wall_template/measure.rb
+++ b/resources/measures/set_wall_template/measure.rb
@@ -1,6 +1,44 @@
-# ComStock™, Copyright (c) 2024 Alliance for Sustainable Energy, LLC. All rights reserved.
+# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.
+# *******************************************************************************
+# OpenStudio(R), Copyright (c) 2008-2018, Alliance for Sustainable Energy, LLC.
+# All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# (4) Other than as required in clauses (1) and (2), distributions in any form
+# of modifications or other derivative works may not use the "OpenStudio"
+# trademark, "OS", "os", or any other confusingly similar designation without
+# specific prior written permission from Alliance for Sustainable Energy, LLC.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER(S) AND ANY CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER(S), ANY CONTRIBUTORS, THE
+# UNITED STATES GOVERNMENT, OR THE UNITED STATES DEPARTMENT OF ENERGY, NOR ANY OF
+# THEIR EMPLOYEES, BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
+# OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
+# see the URL below for information on how to write OpenStudio measures
+# http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/
+
# start the measure
class SetWallTemplate < OpenStudio::Measure::ModelMeasure
require 'openstudio-standards'
@@ -147,8 +185,8 @@ def run(model, runner, user_arguments)
# set additional properties for building
props = model.getBuilding.additionalProperties
- props.setFeature('wall_as_constructed_template', as_constructed_template)
- props.setFeature('wall_template', template)
+ props.setFeature('wall_as_constructed_template',"#{as_constructed_template}")
+ props.setFeature('wall_template',"#{template}")
# Not applicable if the selected template matches the as-constructed template
if template == as_constructed_template
@@ -158,51 +196,60 @@ def run(model, runner, user_arguments)
# Make a standard
reset_log
- standard = Standard.build(template)
-
- # Apply standard constructions to this model at the surface-by-surface level,
- # which will override default contruction sets for the surface types being updated,
- # which is not all surface types.
- types_to_modify = []
- types_to_modify << ['Outdoors', 'Wall']
-
- # Find just those surfaces
- surfaces_to_modify = []
- types_to_modify.each do |boundary_condition, surface_type|
- # Surfaces
- model.getSurfaces.sort.each do |surf|
- next unless surf.outsideBoundaryCondition == boundary_condition
- next unless surf.surfaceType == surface_type
-
- surfaces_to_modify << surf
- end
-
- # SubSurfaces
- model.getSubSurfaces.sort.each do |surf|
- next unless surf.outsideBoundaryCondition == boundary_condition
- next unless surf.subSurfaceType == surface_type
-
- surfaces_to_modify << surf
- end
+ standard = Standard.build("#{template}")
+
+ # Check that a default construction set is defined
+ bldg_def_const_set = model.getBuilding.defaultConstructionSet
+ unless bldg_def_const_set.is_initialized
+ runner.registerError('Model does not have a default construction set.')
+ return false
end
+ bldg_def_const_set = bldg_def_const_set.get
- # Modify these surfaces
- prev_created_consts = {}
- surfaces_to_modify.sort.each do |surf|
- prev_created_consts = standard.planar_surface_apply_standard_construction(surf, climate_zone, prev_created_consts)
+ # Check that a default exterior construction set is defined
+ ext_surf_consts = bldg_def_const_set.defaultExteriorSurfaceConstructions
+ unless ext_surf_consts.is_initialized
+ runner.registerError("Default construction set '#{bldg_def_const_set.name}' has no default exterior surface constructions.")
+ return false
end
+ ext_surf_consts = ext_surf_consts.get
- # List the unique array of constructions
- prev_created_consts.each do |surf_type, construction|
- runner.registerInfo("For #{surf_type.join(' ')}, applied #{construction.name}.")
+ # Check that a default exterior wall is defined
+ unless ext_surf_consts.wallConstruction.is_initialized
+ runner.registerError("Default surface construction set #{ext_surf_consts.name} has no default exterior wall construction.")
+ return false
end
+ old_construction = ext_surf_consts.wallConstruction.get
+ standards_info = old_construction.standardsInformation
- log_messages_to_runner(runner, debug = false)
- reset_log
+ # Get the old wall construction type
+ if standards_info.standardsConstructionType.empty?
+ old_wall_construction_type = 'Not defined'
+ else
+ old_wall_construction_type = standards_info.standardsConstructionType.get
+ end
- if prev_created_consts.empty?
- runner.registerAsNotApplicable("Found no #{surf_type.join(' ')} surfaces in the model to update")
+ # Get the building occupancy type
+ if model.getBuilding.standardsBuildingType.is_initialized
+ model_building_type = model.getBuilding.standardsBuildingType.get
+ else
+ model_building_type = ''
+ end
+ if ['SmallHotel', 'LargeHotel', 'MidriseApartment', 'HighriseApartment'].include?(model_building_type)
+ occ_type = 'Residential'
+ else
+ occ_type = 'Nonresidential'
end
+ climate_zone_set = standard.model_find_climate_zone_set(model, climate_zone)
+ new_construction = standard.model_find_and_add_construction(model,
+ climate_zone_set,
+ 'ExteriorWall',
+ old_wall_construction_type,
+ occ_type)
+ ext_surf_consts.setWallConstruction(new_construction)
+
+ log_messages_to_runner(runner, debug = false)
+ reset_log
return true
end
diff --git a/resources/measures/set_wall_template/measure.xml b/resources/measures/set_wall_template/measure.xml
index fe2a197e3..16ef9645f 100644
--- a/resources/measures/set_wall_template/measure.xml
+++ b/resources/measures/set_wall_template/measure.xml
@@ -3,8 +3,8 @@
3.1
set_wall_template
3d02e4de-a6ad-4d83-8331-078f9fd5bb6f
- 04f226b8-9786-4db9-bec1-67a66dae4166
- 2024-10-16T23:26:59Z
+ 5a9d06f9-a5c3-48c4-a905-733ddfac7ecf
+ 2024-11-12T20:38:45Z
66CE07BA
SetWallTemplate
Set Wall Template
@@ -530,7 +530,7 @@
measure.rb
rb
script
- 1EAE6267
+ 82CC940E
set_wall_template_test.rb
diff --git a/resources/measures/thermal_bridging_derating/LICENSE.md b/resources/measures/thermal_bridging_derating/LICENSE.md
new file mode 100644
index 000000000..a055dadb4
--- /dev/null
+++ b/resources/measures/thermal_bridging_derating/LICENSE.md
@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2020-2024 Denis Bourgeois & Dan Macumber
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
diff --git a/resources/measures/thermal_bridging_derating/README.md b/resources/measures/thermal_bridging_derating/README.md
new file mode 100644
index 000000000..f441954bd
--- /dev/null
+++ b/resources/measures/thermal_bridging_derating/README.md
@@ -0,0 +1,32 @@
+
+
+###### (Automatically generated documentation)
+
+# Thermal Bridging Derating
+
+## Description
+Derates opaque construction thermal resistance for major thermal bridges.
+
+## Modeler Description
+This measure is adapted from the Thermal Bridging and Derating measure. Details, including default psi value sets, are avialble at rd2.github.io/tbd
+
+## Measure Type
+ModelMeasure
+
+## Taxonomy
+
+
+## Arguments
+
+
+### Default thermal bridge set
+e.g. '90.1.22|steel.m|unmitigated'
+**Name:** option,
+**Type:** Choice,
+**Units:** ,
+**Required:** false,
+**Model Dependent:** false
+
+
+
+
diff --git a/resources/measures/thermal_bridging_derating/README.md.erb b/resources/measures/thermal_bridging_derating/README.md.erb
new file mode 100644
index 000000000..4deb9ae5f
--- /dev/null
+++ b/resources/measures/thermal_bridging_derating/README.md.erb
@@ -0,0 +1,42 @@
+<%#= README.md.erb is used to auto-generate README.md. %>
+<%#= To manually maintain README.md throw away README.md.erb and manually edit README.md %>
+###### (Automatically generated documentation)
+
+# <%= name %>
+
+## Description
+<%= description %>
+
+## Modeler Description
+<%= modelerDescription %>
+
+## Measure Type
+<%= measureType %>
+
+## Taxonomy
+<%= taxonomy %>
+
+## Arguments
+
+<% arguments.each do |argument| %>
+### <%= argument[:display_name] %>
+<%= argument[:description] %>
+**Name:** <%= argument[:name] %>,
+**Type:** <%= argument[:type] %>,
+**Units:** <%= argument[:units] %>,
+**Required:** <%= argument[:required] %>,
+**Model Dependent:** <%= argument[:model_dependent] %>
+<% end %>
+
+<% if arguments.size == 0 %>
+<%= "This measure does not have any user arguments" %>
+<% end %>
+
+<% if outputs.size > 0 %>
+## Outputs
+<% output_names = [] %>
+<% outputs.each do |output| %>
+<% output_names << output[:display_name] %>
+<% end %>
+<%= output_names.join(", ") %>
+<% end %>
\ No newline at end of file
diff --git a/resources/measures/thermal_bridging_derating/measure.rb b/resources/measures/thermal_bridging_derating/measure.rb
new file mode 100644
index 000000000..107f0e189
--- /dev/null
+++ b/resources/measures/thermal_bridging_derating/measure.rb
@@ -0,0 +1,109 @@
+# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
+# See top level LICENSE.txt file for license terms.
+# *******************************************************************************
+# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# (4) Other than as required in clauses (1) and (2), distributions in any form
+# of modifications or other derivative works may not use the "OpenStudio"
+# trademark, "OS", "os", or any other confusingly similar designation without
+# specific prior written permission from Alliance for Sustainable Energy, LLC.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER(S) AND ANY CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER(S), ANY CONTRIBUTORS, THE
+# UNITED STATES GOVERNMENT, OR THE UNITED STATES DEPARTMENT OF ENERGY, NOR ANY OF
+# THEIR EMPLOYEES, BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
+# OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
+require 'tbd'
+
+class ThermalBridgingDerating < OpenStudio::Measure::ModelMeasure
+
+ # Returns measure name
+ #
+ # @return [String] measure name
+ def name
+ return 'Thermal Bridging Derating'
+ end
+
+ # Returns measure description
+ #
+ # @return [String] measure description
+ def description
+ return 'Derates opaque construction thermal resistance for major thermal bridges.'
+ end
+
+ # Returns measure modeler description
+ #
+ # @return [String] measure modeler description
+ def modeler_description
+ return 'This measure is adapted from the Thermal Bridging and Derating measure. Details, including default psi value sets, are avialble at rd2.github.io/tbd'
+ end
+
+ # Returns measure arguments
+ #
+ # @param model [OpenStudio::Model::Model] An OpenStudio model
+ # @return [OpenStudio::Measure::OSArgumentVector] validated arguments
+ def arguments(model = nil)
+ args = OpenStudio::Measure::OSArgumentVector.new
+
+ # psi value sets are defined in psi.rb on the TBD github repository:
+ # https://github.com/rd2/tbd/blob/a250fc0bd1c0db454d21720a68bf6c980d648c8f/lib/tbd/psi.rb#L124
+ choices = OpenStudio::StringVector.new
+ psi = TBD::PSI.new
+ psi.set.keys.each { |k| choices << k.to_s }
+
+ option = OpenStudio::Measure::OSArgument.makeChoiceArgument('option', choices, false)
+ option.setDisplayName('Default thermal bridge set')
+ option.setDescription("e.g. '90.1.22|steel.m|unmitigated'")
+ option.setDefaultValue('poor (BETBG)')
+ args << option
+
+ return args
+ end
+
+ # Runs the thermal bridging deratign measure
+ #
+ # @param model [OpenStudio::Model::Model] a model
+ # @param runner [OpenStudio::Measure::OSRunner] Measure runner
+ # @param [OpenStudio::Measure::OSArgumentVector] args Measure argument list
+ # @option args [#to_s] :option ("poor (BETBG)") selected PSI set
+ # @return [Bool] whether TBD Measure is successful
+ def run(model, runner, args)
+ super(model, runner, args)
+
+ argh = {}
+ argh[:option] = runner.getStringArgumentValue('option', args)
+
+ return false unless runner.validateUserArguments(arguments(model), args)
+
+ TBD.clean! # clean tbd logging
+ tbd = TBD.process(model, argh)
+ TBD.exit(runner, argh)
+
+ return true
+ end
+end
+
+# register the measure to be used by the application
+ThermalBridgingDerating.new.registerWithApplication
diff --git a/resources/measures/thermal_bridging_derating/measure.xml b/resources/measures/thermal_bridging_derating/measure.xml
new file mode 100644
index 000000000..043fe3b3a
--- /dev/null
+++ b/resources/measures/thermal_bridging_derating/measure.xml
@@ -0,0 +1,224 @@
+
+
+ 3.1
+ thermal_bridging_derating
+ e80a588e-f52d-4244-888a-3c95bd845604
+ 393d3a57-9d3d-441f-bf6d-b0e117f68de5
+ 2024-08-08T21:48:54Z
+ D69419EB
+ ThermalBridgingDerating
+ Thermal Bridging Derating
+ Derates opaque construction thermal resistance for major thermal bridges.
+ This measure is adapted from the Thermal Bridging and Derating measure. Details, including default psi value sets, are avialble at rd2.github.io/tbd
+
+
+ option
+ Default thermal bridge set
+ e.g. '90.1.22|steel.m|unmitigated'
+ Choice
+ false
+ false
+ poor (BETBG)
+
+
+ poor (BETBG)
+ poor (BETBG)
+
+
+ regular (BETBG)
+ regular (BETBG)
+
+
+ efficient (BETBG)
+ efficient (BETBG)
+
+
+ spandrel (BETBG)
+ spandrel (BETBG)
+
+
+ spandrel HP (BETBG)
+ spandrel HP (BETBG)
+
+
+ code (Quebec)
+ code (Quebec)
+
+
+ uncompliant (Quebec)
+ uncompliant (Quebec)
+
+
+ 90.1.22|steel.m|default
+ 90.1.22|steel.m|default
+
+
+ 90.1.22|steel.m|unmitigated
+ 90.1.22|steel.m|unmitigated
+
+
+ 90.1.22|mass.ex|default
+ 90.1.22|mass.ex|default
+
+
+ 90.1.22|mass.ex|unmitigated
+ 90.1.22|mass.ex|unmitigated
+
+
+ 90.1.22|mass.in|default
+ 90.1.22|mass.in|default
+
+
+ 90.1.22|mass.in|unmitigated
+ 90.1.22|mass.in|unmitigated
+
+
+ 90.1.22|wood.fr|default
+ 90.1.22|wood.fr|default
+
+
+ 90.1.22|wood.fr|unmitigated
+ 90.1.22|wood.fr|unmitigated
+
+
+ (non thermal bridging)
+ (non thermal bridging)
+
+
+
+
+
+
+
+ Envelope.Opaque
+
+
+
+ Intended Software Tool
+ Apply Measure Now
+ string
+
+
+ Intended Software Tool
+ OpenStudio Application
+ string
+
+
+ Intended Software Tool
+ Parametric Analysis Tool
+ string
+
+
+ Intended Use Case
+ Model Articulation
+ string
+
+
+ Intended Use Case
+ Calibration
+ string
+
+
+ Intended Use Case
+ Sensitivity Analysis
+ string
+
+
+ Intended Use Case
+ New Construction EE
+ string
+
+
+ Intended Use Case
+ Retrofit EE
+ string
+
+
+ Measure Type
+ ModelMeasure
+ string
+
+
+ Measure Language
+ Ruby
+ string
+
+
+ Intended Software Tool
+ Apply Measure Now
+ string
+
+
+ Intended Software Tool
+ OpenStudio Application
+ string
+
+
+ Intended Software Tool
+ Parametric Analysis Tool
+ string
+
+
+ Intended Use Case
+ Model Articulation
+ string
+
+
+ Intended Use Case
+ Calibration
+ string
+
+
+ Intended Use Case
+ Sensitivity Analysis
+ string
+
+
+ Intended Use Case
+ New Construction EE
+ string
+
+
+ Intended Use Case
+ Retrofit EE
+ string
+
+
+
+
+ LICENSE.md
+ md
+ license
+ 5C9BFB50
+
+
+ README.md
+ md
+ readme
+ 02396931
+
+
+ README.md.erb
+ erb
+ readmeerb
+ 703C9964
+
+
+
+ OpenStudio
+ 2.9.1
+ 2.9.1
+
+ measure.rb
+ rb
+ script
+ 660DE5F4
+
+
+ thermal_bridging_derating_test.rb
+ rb
+ test
+ FDCBB810
+
+
+
diff --git a/resources/measures/thermal_bridging_derating/tests/thermal_bridging_derating_test.rb b/resources/measures/thermal_bridging_derating/tests/thermal_bridging_derating_test.rb
new file mode 100644
index 000000000..f57433f8e
--- /dev/null
+++ b/resources/measures/thermal_bridging_derating/tests/thermal_bridging_derating_test.rb
@@ -0,0 +1,180 @@
+# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
+# See top level LICENSE.txt file for license terms.
+# *******************************************************************************
+# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# (4) Other than as required in clauses (1) and (2), distributions in any form
+# of modifications or other derivative works may not use the "OpenStudio"
+# trademark, "OS", "os", or any other confusingly similar designation without
+# specific prior written permission from Alliance for Sustainable Energy, LLC.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER(S) AND ANY CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER(S), ANY CONTRIBUTORS, THE
+# UNITED STATES GOVERNMENT, OR THE UNITED STATES DEPARTMENT OF ENERGY, NOR ANY OF
+# THEIR EMPLOYEES, BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
+# OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
+require "openstudio"
+require "openstudio/measure/ShowRunnerOutput"
+require "minitest/autorun"
+require "fileutils"
+require_relative "../measure.rb"
+
+class ThermalBridgingDeratingTest < Minitest::Test
+ # return file paths to test models in test directory
+ def models_for_tests
+ paths = Dir.glob(File.join(File.dirname(__FILE__), '../../../tests/models/*.osm'))
+ paths = paths.map { |path| File.expand_path(path) }
+ return paths
+ end
+
+ # return file paths to epw files in test directory
+ def epws_for_tests
+ paths = Dir.glob(File.join(File.dirname(__FILE__), '../../../tests/weather/*.epw'))
+ paths = paths.map { |path| File.expand_path(path) }
+ return paths
+ end
+
+ def load_model(osm_path)
+ translator = OpenStudio::OSVersion::VersionTranslator.new
+ model = translator.loadModel(OpenStudio::Path.new(osm_path))
+ assert(!model.empty?)
+ model = model.get
+ return model
+ end
+
+ def run_dir(test_name)
+ # always generate test output in specially named 'output' directory so result files are not made part of the measure
+ return File.join(File.dirname(__FILE__),"output","#{test_name}")
+ end
+
+ def model_input_path(osm_name)
+ # return models_for_tests.select { |x| set[:model] == osm_name }
+ return File.expand_path(File.join(File.dirname(__FILE__), '../../../tests/models', osm_name))
+ end
+
+ def epw_input_path(epw_name)
+ return File.join(File.dirname(__FILE__), '../../../tests/weather', epw_name)
+ end
+
+ def model_output_path(test_name)
+ return "#{run_dir(test_name)}/#{test_name}_out.osm"
+ end
+
+ def sql_path(test_name)
+ return "#{run_dir(test_name)}/run/eplusout.sql"
+ end
+
+ def report_path(test_name)
+ return "#{run_dir(test_name)}/reports/eplustbl.html"
+ end
+
+ # applies the measure and then runs the model
+ def apply_measure_and_run(test_name, measure, argument_map, osm_path, epw_path, run_model: false, model: nil)
+ assert(File.exist?(osm_path))
+ assert(File.exist?(epw_path))
+
+ # create run directory if it does not exist
+ if !File.exist?(run_dir(test_name))
+ FileUtils.mkdir_p(run_dir(test_name))
+ end
+ assert(File.exist?(run_dir(test_name)))
+
+ # remove prior runs if they exist
+ if File.exist?(model_output_path(test_name))
+ FileUtils.rm(model_output_path(test_name))
+ end
+ if File.exist?(report_path(test_name))
+ FileUtils.rm(report_path(test_name))
+ end
+
+ runner = OpenStudio::Measure::OSRunner.new(OpenStudio::WorkflowJSON.new)
+
+ # load the test model
+ if model.nil?
+ model = load_model(osm_path)
+ end
+
+ # set model weather file
+ epw_file = OpenStudio::EpwFile.new(OpenStudio::Path.new(epw_path))
+ OpenStudio::Model::WeatherFile.setWeatherFile(model, epw_file)
+ assert(model.weatherFile.is_initialized)
+
+ # run the measure
+ puts "\nAPPLYING MEASURE..."
+ measure.run(model, runner, argument_map)
+ result = runner.result
+ result_success = result.value.valueName == 'Success'
+
+ # Show the output
+ show_output(result)
+
+ # Save model
+ model.save(model_output_path(test_name), true)
+
+ if run_model && result_success
+ puts "\nRUNNING MODEL..."
+
+ std = Standard.build('90.1-2013')
+ std.model_run_simulation_and_log_errors(model, run_dir(test_name))
+
+ # Check that the model ran successfully
+ assert(File.exist?(sql_path(test_name)))
+ end
+
+ return result
+ end
+
+ def test_number_of_arguments_and_argument_names
+ measure = ThermalBridgingDerating.new
+ model = OpenStudio::Model::Model.new
+ arguments = measure.arguments(model)
+ assert_equal(1, arguments.size)
+ end
+
+ def test_efficient_thermal_bridging
+ # select
+ osm_name = '361_Strip_Mall_PSZ_Gas_3a.osm'
+ epw_name = 'TN_KNOXVILLE_723260_12.epw'
+ osm_path = model_input_path(osm_name)
+ epw_path = epw_input_path(epw_name)
+
+ # create a new instance of the measure
+ measure = ThermalBridgingDerating.new
+
+ # Load the model; only used here for populating arguments
+ model = load_model(osm_path)
+ arguments = measure.arguments(model)
+ argument_map = OpenStudio::Measure::OSArgumentMap.new
+
+ # set arguments
+ option = arguments[0].clone
+ assert(option.setValue('efficient (BETBG)'))
+ argument_map['option'] = option
+
+ # Apply the measure to the model and optionally run the model
+ result = apply_measure_and_run(__method__, measure, argument_map, osm_path, epw_path, run_model: false)
+ assert_equal('Success', result.value.valueName)
+ end
+end
diff --git a/resources/measures/upgrade_env_exterior_wall_insulation/measure.rb b/resources/measures/upgrade_env_exterior_wall_insulation/measure.rb
index 88de7ff4d..24bf30147 100644
--- a/resources/measures/upgrade_env_exterior_wall_insulation/measure.rb
+++ b/resources/measures/upgrade_env_exterior_wall_insulation/measure.rb
@@ -72,9 +72,6 @@ def run(model, runner, user_arguments)
return false
end
- # build standard to use OS standards methods
- template = 'ComStock 90.1-2013'
- std = Standard.build(template)
# get climate zone to set target_r_val_ip
climate_zone = OpenstudioStandards::Weather.model_get_climate_zone(model)
diff --git a/resources/measures/upgrade_env_exterior_wall_insulation/measure.xml b/resources/measures/upgrade_env_exterior_wall_insulation/measure.xml
index 5d2f052a4..c426f536d 100644
--- a/resources/measures/upgrade_env_exterior_wall_insulation/measure.xml
+++ b/resources/measures/upgrade_env_exterior_wall_insulation/measure.xml
@@ -3,8 +3,8 @@
3.1
exterior_wall_insulation
7eecb48f-34ea-4cf7-af27-8568580dead6
- f77caec3-8e54-4b9c-ad60-01ea1df5c693
- 2024-06-20T18:58:42Z
+ c57405a4-f9cf-47e6-9611-35ef65998cab
+ 2024-09-09T21:44:23Z
4E797983
ExteriorWallInsulation
Exterior Wall Insulation
@@ -54,13 +54,13 @@
measure.rb
rb
script
- 5BBCBDEE
+ 29F12AB4
- measure_test.rb
+ upgrade_env_exterior_wall_insulation_test.rb
rb
test
- 09A58639
+ 978E759C
diff --git a/resources/measures/upgrade_env_exterior_wall_insulation/tests/measure_test.rb b/resources/measures/upgrade_env_exterior_wall_insulation/tests/upgrade_env_exterior_wall_insulation_test.rb
similarity index 84%
rename from resources/measures/upgrade_env_exterior_wall_insulation/tests/measure_test.rb
rename to resources/measures/upgrade_env_exterior_wall_insulation/tests/upgrade_env_exterior_wall_insulation_test.rb
index e25299d07..48a8a0c71 100644
--- a/resources/measures/upgrade_env_exterior_wall_insulation/tests/measure_test.rb
+++ b/resources/measures/upgrade_env_exterior_wall_insulation/tests/upgrade_env_exterior_wall_insulation_test.rb
@@ -106,10 +106,6 @@ def apply_measure_and_run(test_name, measure, argument_map, osm_path, epw_path,
end
assert(File.exist?(run_dir(test_name)))
- # change into run directory for tests
- start_dir = Dir.pwd
- Dir.chdir run_dir(test_name)
-
# remove prior runs if they exist
if File.exist?(model_output_path(test_name))
FileUtils.rm(model_output_path(test_name))
@@ -118,21 +114,16 @@ def apply_measure_and_run(test_name, measure, argument_map, osm_path, epw_path,
FileUtils.rm(report_path(test_name))
end
- # copy the osm and epw to the test directory
- new_osm_path = "#{run_dir(test_name)}/#{File.basename(osm_path)}"
- FileUtils.cp(osm_path, new_osm_path)
- new_epw_path = "#{run_dir(test_name)}/#{File.basename(epw_path)}"
- FileUtils.cp(epw_path, new_epw_path)
# create an instance of a runner
runner = OpenStudio::Measure::OSRunner.new(OpenStudio::WorkflowJSON.new)
# load the test model
if model.nil?
- model = load_model(new_osm_path)
+ model = load_model(osm_path)
end
# set model weather file
- epw_file = OpenStudio::EpwFile.new(OpenStudio::Path.new(new_epw_path))
+ epw_file = OpenStudio::EpwFile.new(OpenStudio::Path.new(epw_path))
OpenStudio::Model::WeatherFile.setWeatherFile(model, epw_file)
assert(model.weatherFile.is_initialized)
@@ -158,9 +149,6 @@ def apply_measure_and_run(test_name, measure, argument_map, osm_path, epw_path,
assert(File.exist?(sql_path(test_name)))
end
- # change back directory
- Dir.chdir(start_dir)
-
return result
end
@@ -274,6 +262,66 @@ def test_r_value_cz_7
# Apply the measure to the model and optionally run the model
result = apply_measure_and_run(__method__, measure, argument_map, osm_path, epw_path, run_model: false)
+ model = load_model(model_output_path(__method__))
+ model.getSurfaces.each do |surface|
+ next unless (surface.outsideBoundaryCondition == 'Outdoors') && (surface.surfaceType == 'Wall')
+ surf_const = surface.construction.get.to_LayeredConstruction.get
+ new_r_val_si = 1.0 / surface.thermalConductance.to_f
+ new_r_val_ip = OpenStudio.convert(new_r_val_si, 'm^2*K/W', 'ft^2*h*R/Btu').get
+ new_ext_surf_material = surf_const.getLayer(0)
+ insul = surf_const.insulation.get
+ insul_thick_in = OpenStudio.convert(insul.thickness, 'm', 'in').get
+
+ # Check that original R-value was below target threshold
+ assert(old_r_val_ip < new_r_val_ip, "For surface #{surface.name.get}, the new R-value #{new_r_val_ip.round(2)} ft^2*h*R/Btu is less than or equal to the old R-value #{old_r_val_ip.round(2)} ft^2*h*R/Btu.")
+
+ # Check that exterior surface material doesn't change
+ assert_equal(old_ext_surf_material.name.get.to_s, new_ext_surf_material.name.get.to_s)
+
+ # Check that the new R-value matches the target
+ tolerance = 5.0 * 0.5 # R-5/inch * max 1/2 inch off from rounding to nearest inch
+ assert_in_delta(target_r_value_ip, new_r_val_ip, tolerance)
+
+ # Check that the thickness of the added insulation is rounded to nearest inch
+ assert_in_epsilon(1.0, insul_thick_in, 0.001)
+ break
+ end
+ end
+
+ def test_existing_thermal_bridging
+ osm_name = 'thermal_bridging_applied.osm'
+ epw_name = 'CA_LOS-ANGELES-DOWNTOWN-USC_722874S_16.epw'
+
+ # Test expectations
+ target_r_value_ip = 21.0 # 7
+
+ osm_path = model_input_path(osm_name)
+ epw_path = epw_input_path(epw_name)
+
+ # Create an instance of the measure
+ measure = ExteriorWallInsulation.new
+
+ # Load the model; only used here for populating arguments
+ model = load_model(osm_path)
+ arguments = measure.arguments(model)
+ argument_map = OpenStudio::Measure::OSArgumentMap.new
+
+ # Check that the starting R-value is less than the target
+ old_r_val_ip = 0
+ old_ext_surf_material = nil
+ model.getSurfaces.each do |surface|
+ next unless (surface.outsideBoundaryCondition == 'Outdoors') && (surface.surfaceType == 'Wall')
+ surf_const = surface.construction.get.to_LayeredConstruction.get
+ old_r_val_si = 1 / surface.thermalConductance.to_f
+ old_r_val_ip = OpenStudio.convert(old_r_val_si, 'm^2*K/W', 'ft^2*h*R/Btu').get
+ old_ext_surf_material = surf_const.getLayer(0)
+ break
+ end
+ assert(old_r_val_ip < target_r_value_ip)
+
+ # Apply the measure to the model and optionally run the model
+ result = apply_measure_and_run(__method__, measure, argument_map, osm_path, epw_path, run_model: false)
+
model = load_model(model_output_path(__method__))
model.getSurfaces.each do |surface|
next unless (surface.outsideBoundaryCondition == 'Outdoors') && (surface.surfaceType == 'Wall')
diff --git a/resources/measures/upgrade_env_roof_insul_aedg/measure.rb b/resources/measures/upgrade_env_roof_insul_aedg/measure.rb
index dcd653744..f512f21a5 100644
--- a/resources/measures/upgrade_env_roof_insul_aedg/measure.rb
+++ b/resources/measures/upgrade_env_roof_insul_aedg/measure.rb
@@ -75,9 +75,6 @@ def run(model, runner, user_arguments)
# set limit for minimum insulation in IP units -- this is used to limit input and for inferring insulation layer in construction
min_exp_r_val_ip = 1.0
- # build standard to use OS standards methods
- template = 'ComStock 90.1-2019'
- std = Standard.build(template)
# get climate zone to set target_r_val_ip
climate_zone = OpenstudioStandards::Weather.model_get_climate_zone(model)
diff --git a/resources/measures/upgrade_env_roof_insul_aedg/measure.xml b/resources/measures/upgrade_env_roof_insul_aedg/measure.xml
index 3f5302b9e..35a0c9501 100644
--- a/resources/measures/upgrade_env_roof_insul_aedg/measure.xml
+++ b/resources/measures/upgrade_env_roof_insul_aedg/measure.xml
@@ -3,8 +3,8 @@
3.1
env_roof_insul_aedg
8afedac6-d5b8-4ee6-80d9-107c5cd77b0e
- 370fdf61-e62c-43a8-8487-0fd098f03fda
- 2024-06-20T18:58:42Z
+ e61c3b69-deb1-4490-9be0-7239edee2788
+ 2024-09-09T21:44:40Z
A465C8A5
EnvRoofInsulAedg
Roof Insulation AEDG
@@ -81,13 +81,13 @@
measure.rb
rb
script
- E6813C8D
+ 5B95CB09
- env_roof_insul_aedg_test.rb
+ upgrade_env_roof_insul_aedg_test.rb
rb
test
- E22EA670
+ 2C804AFF