[fix] 登録されたデータが編集モーダルに反映されるよう修正 #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikahana
reviewed
Mar 19, 2024
Comment on lines
35
to
55
| useEffect(() => { | ||
| const teacher = props.teachers.find((teacher) => teacher.departmentID === departmentID); | ||
| if (teacher && teacher.id) { | ||
| setFormData({ ...formData, teacherID: teacher.id }); | ||
| if (defaultValue == false) { | ||
| const selectedTeacher = props.teachers.find( | ||
| (teacher) => teacher.id === props.fundInformation.teacherID, | ||
| ); | ||
| if (selectedTeacher?.id) { | ||
| setDepartmentID(selectedTeacher.departmentID); | ||
| setFormData({ ...formData, teacherID: selectedTeacher.id }); | ||
| } | ||
| setTimeout(() => { | ||
| setDefaultValue(true); | ||
| }); | ||
| } else { | ||
| const relatedTeachers = props.teachers.filter( | ||
| (teacher) => teacher.departmentID === departmentID, | ||
| ); | ||
| if (relatedTeachers) { | ||
| setFormData({ ...formData, teacherID: relatedTeachers[0].id || 0 }); | ||
| } | ||
| } | ||
| }, [departmentID]); | ||
| }, [departmentID, props.teachers]); |
There was a problem hiding this comment.
defaultValueなくてもいけるのではないでしょうか
useEffect(() => {
const selectedTeacher = props.teachers.find(
(teacher) => teacher.id === props.fundInformation.teacherID,
);
if (selectedTeacher?.id) {
setDepartmentID(selectedTeacher.departmentID);
setFormData({ ...formData, teacherID: selectedTeacher.id });
} else {
const relatedTeachers = props.teachers.filter(
(teacher) => teacher.departmentID === departmentID,
);
if (relatedTeachers) {
setFormData({ ...formData, teacherID: relatedTeachers[0].id || 0 });
}
}
}, [departmentID, props.teachers]);
Kubosaka
requested changes
Mar 21, 2024
view/next-project/src/components/fund_information/EditModal.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #663
概要
Issue内容は、担当者が各局の一番上の人になるバグの解消です。
しかし、教員の所属・教員名・担当者の局の項目でも同様のバグが発生していたため、まとめて修正しました。
修正内容は、各項目の初期値として登録される値を、既に登録されている内容から参照するように変更しました。
画面スクリーンショット等
テスト項目
http://localhost:3000/fund_informationsへアクセスできることを確認する。(各項目が全て1番目の要素に初期化されていないか。)
備考
24/03/29 更新：モーダルの展開時はpropsの値を表示し、セレクト要素の選択時にUseEffectの再レンダリングで教員名の初期値を設定するようにしました。もっと良い方法あれば教えて下さい。