Take token count quantization of fused attention into consideration for CP results correction #1396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fused attention has token count quantization. This can make T of
sfotmax_lse
mismatch with Q and O. For example, both T=1000 and T=500 will create T=1024 insoftmax_lse
, so we cannot assume half of T will have 2x smaller shape ofsoftmax_lse.
Fix CP results correction by taking this quantization into consideration.Type of change
Checklist: