-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate CUB iterators existing in Thrust #3304
Deprecate CUB iterators existing in Thrust #3304
Conversation
3197c5d
to
11a30b9
Compare
d66b741
to
286521b
Compare
/ok to test |
🟨 CI finished in 1h 57m: Pass: 92%/78 | Total: 2d 04h | Avg: 40m 14s | Max: 1h 11m | Hits: 180%/12368
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 78)
# | Runner |
---|---|
53 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
2a77c92
to
23a7d1a
Compare
🟨 CI finished in 1h 47m: Pass: 94%/78 | Total: 2d 05h | Avg: 41m 02s | Max: 1h 09m | Hits: 179%/12340
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 78)
# | Runner |
---|---|
53 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
23a7d1a
to
6e6cf8d
Compare
🟨 CI finished in 2h 04m: Pass: 94%/78 | Total: 2d 08h | Avg: 43m 39s | Max: 1h 18m | Hits: 125%/12720
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 78)
# | Runner |
---|---|
53 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
6e6cf8d
to
a3a76ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it when we remove stuff. Great Work!
a3a76ff
to
75fe5db
Compare
This is talking quite some effort to make all the Thrust iterator machinery compileable by NVRTC. |
a270cf2
to
b53e8ae
Compare
I think it's better that we only backport a deprecation and warning suppression to CCCL 2.8, leaving Thrust untouched, and then properly rework Thrust iterators for CCCL 3.0. I will change this PR. |
I pushed the state of this PR into #3480, where we can continue the replacement and replace this PR by a pure deprecation now. |
e6b9bb8
to
953121c
Compare
We keep CUB iterators inside the CUB implementation headers, because some of those are exposed to NVRTC which cannot compile Thrust iterators yet.
4aa9143
to
e8499df
Compare
🟩 CI finished in 1h 43m: Pass: 100%/90 | Total: 2d 14h | Avg: 41m 41s | Max: 1h 12m | Hits: 284%/12772
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 90)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
Backport failed for Please cherry-pick the changes locally. git fetch origin branch/2.8.x
git worktree add -d .worktree/backport-3304-to-branch/2.8.x origin/branch/2.8.x
cd .worktree/backport-3304-to-branch/2.8.x
git checkout -b backport-3304-to-branch/2.8.x
ancref=$(git merge-base 010a59297ecaf929c2997217725f87071187f39d e8499df009a9dbdac3a26d2a321b22c8bda2aac4)
git cherry-pick -x $ancref..e8499df009a9dbdac3a26d2a321b22c8bda2aac4 |
We keep CUB iterators inside the CUB implementation headers, because some of those are exposed to NVRTC which cannot compile Thrust iterators yet.
This P R deprecates the CUB iterators that also exist in Thrust. Uses of CUB iterators in tests and benchmarks are replaced by Thrust iterators. Uses of CUB iterators in the headers of CUB/Thrust are not replaced, since the Thrust iterator machinery does not compile under NVRTC. This will be addressed with #3480 for CCCL 3.0.
Fixes: #3261
cub.bench.reduce.arg_extrema.base
did not change for SM86.