Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate thrust::optional #3307

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Deprecate thrust::optional #3307

wants to merge 8 commits into from
+38 −14

Conversation

bernhardmgruber
Copy link
Contributor

Fixes: #3306

@bernhardmgruber bernhardmgruber requested review from a team as code owners January 9, 2025 10:49
@bernhardmgruber bernhardmgruber added thrust For all items related to Thrust. backport branch/2.8.x labels Jan 9, 2025
miscco
miscco reviewed Jan 9, 2025
View reviewed changes
thrust/thrust/optional.h Outdated Show resolved Hide resolved
thrust/thrust/system/cuda/detail/future.inl Show resolved Hide resolved
@miscco miscco requested a review from a team as a code owner January 9, 2025 12:56
@bernhardmgruber bernhardmgruber force-pushed the depr_optional branch 2 times, most recently from 141e754 to 6a25f66 Compare January 13, 2025 11:17
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bernhardmgruber
Copy link
Contributor Author

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco left review comments

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport branch/2.8.x thrust For all items related to Thrust.
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate thrust::optional
2 participants
@bernhardmgruber @miscco