-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Catch2 3.8 #3310
base: main
Are you sure you want to change the base?
Upgrade to Catch2 3.8 #3310
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
593b238
to
bdbbada
Compare
/ok to test |
1 similar comment
/ok to test |
🟨 CI finished in 1h 10m: Pass: 95%/148 | Total: 1d 16h | Avg: 16m 34s | Max: 54m 04s | Hits: 524%/21732
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
python | |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 148)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
23 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
cc7ad79
to
5aaa92c
Compare
/ok to test |
🟨 CI finished in 1h 13m: Pass: 95%/148 | Total: 1d 05h | Avg: 11m 48s | Max: 1h 02m | Hits: 533%/21732
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
python | |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 148)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
23 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
🟨 CI finished in 1h 14m: Pass: 97%/148 | Total: 1d 05h | Avg: 12m 05s | Max: 1h 12m | Hits: 529%/24387
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
python | |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 148)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
23 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
pre-commit.ci autofix |
ff6cdab
to
9fbbde1
Compare
/ok to test |
1 similar comment
/ok to test |
🟨 CI finished in 1h 14m: Pass: 95%/148 | Total: 1d 05h | Avg: 11m 48s | Max: 1h 05m | Hits: 547%/21732
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
python | |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 148)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
23 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
4f5b938
to
64b24cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for c/parallel/test and c2h/include/c2h
(I didn't look at the rest)
I'm glad to see that the #define CATCH_CONFIG_RUNNER
are no longer needed.
The CATCH_INTERNAL_START_WARNINGS_SUPPRESSION
etc. workarounds look worrisome, is there an upstream bug that could be referenced along with the workarounds?
🟨 CI finished in 1h 32m: Pass: 99%/148 | Total: 1d 05h | Avg: 11m 51s | Max: 1h 10m | Hits: 520%/25782
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
python | |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 148)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
23 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
I think catchorg/Catch2#2636 relates. I can add a comment. |
🟩 CI finished in 2h 07m: Pass: 100%/148 | Total: 1d 05h | Avg: 11m 51s | Max: 1h 10m | Hits: 520%/25782
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
python | |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 148)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
23 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
33e1ed0
to
65fc077
Compare
Fixes: #1724