Refactor `<cuda/std/cstring>` #3484

davebayer · 2025-01-22T17:46:24Z

This PR refactors <cuda/std/cstring> and implements missing character array manipulation on device.

Changes:

removed imports of functions that are __host__ only, such as strlen and strcat
<cuda/std/cstring> is publicly available
all array manipulation functions such as memcpy, memset and memcmp are available in device code

copy-pr-bot · 2025-01-22T17:46:28Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

libcudacxx/include/cuda/std/detail/libcxx/include/cstring

miscco · 2025-01-23T08:56:27Z

/ok to test

miscco · 2025-01-23T09:43:47Z

libcudacxx/include/cuda/std/__atomic/types/common.h

-_CCCL_HOST_DEVICE inline int __atomic_memcmp(void const* __lhs, void const* __rhs, size_t __count)
-{
-  NV_DISPATCH_TARGET(
-    NV_IS_DEVICE,
-    (unsigned char const* __lhs_c; unsigned char const* __rhs_c;
-     // NVCC recommended laundering through inline asm to compare padding bytes.
-     asm("mov.b64 %0, %2;\n mov.b64 %1, %3;" : "=l"(__lhs_c), "=l"(__rhs_c) : "l"(__lhs), "l"(__rhs));
-     while (__count--) {
-       auto const __lhs_v = *__lhs_c++;
-       auto const __rhs_v = *__rhs_c++;
-       if (__lhs_v < __rhs_v)
-       {
-         return -1;
-       }
-       if (__lhs_v > __rhs_v)
-       {
-         return 1;
-       }
-     } return 0;),
-    NV_IS_HOST,
-    (return _CUDA_VSTD::memcmp(__lhs, __rhs, __count);))
-}
-


@wmaxey I am not sure whether that is still needed?

github-actions · 2025-01-23T16:15:23Z

🟨 CI finished in 7h 17m: Pass: 97%/135 | Total: 3d 05h | Avg: 34m 30s | Max: 1h 18m | Hits: 253%/23315

🟨 libcudacxx: Pass: 91%/37 | Total: 15h 37m | Avg: 25m 19s | Max: 1h 04m | Hits: 439%/10085

🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  91%/35  | Total: 14h 56m | Avg: 25m 36s | Max:  1h 04m | Hits: 439%/10085 
  🟩 arm64              Pass: 100%/2   | Total: 40m 50s | Avg: 20m 25s | Max: 21m 23s
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/4   | Total:  1h 15m | Avg: 18m 50s | Max: 25m 51s
  🔍 nvcc               Pass:  90%/33  | Total: 14h 21m | Avg: 26m 06s | Max:  1h 04m | Hits: 439%/10085 
🔍 cxx_family: GCC 🔍
  🟩 Clang              Pass: 100%/15  | Total:  5h 48m | Avg: 23m 15s | Max:  1h 01m
  🔍 GCC                Pass:  81%/16  | Total:  6h 29m | Avg: 24m 19s | Max:  1h 04m
  🟩 MSVC               Pass: 100%/4   | Total:  2h 15m | Avg: 33m 59s | Max: 41m 20s | Hits: 439%/10085 
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 02m | Avg: 31m 29s | Max: 32m 24s
🔍 jobs: Build 🔍
  🔍 Build              Pass:  90%/32  | Total: 12h 27m | Avg: 23m 21s | Max: 41m 20s | Hits: 439%/10085 
  🟩 NVRTC              Pass: 100%/2   | Total:  1h 01m | Avg: 30m 56s | Max: 33m 32s
  🟩 Test               Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 04m
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  1m 58s | Avg:  1m 58s | Max:  1m 58s
🔍 std: 17 🔍
  🔍 17                 Pass:  80%/15  | Total:  6h 09m | Avg: 24m 37s | Max: 33m 35s | Hits: 435%/7448  
  🟩 20                 Pass: 100%/21  | Total:  9h 25m | Avg: 26m 56s | Max:  1h 04m | Hits: 449%/2637  
🟨 ctk
  🟨 12.0               Pass:  80%/5   | Total:  1h 44m | Avg: 20m 49s | Max: 30m 02s | Hits: 435%/2476  
  🟩 12.5               Pass: 100%/2   | Total:  1h 02m | Avg: 31m 29s | Max: 32m 24s
  🟨 12.6               Pass:  93%/30  | Total: 12h 50m | Avg: 25m 40s | Max:  1h 04m | Hits: 440%/7609  
🟨 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  1h 15m | Avg: 18m 50s | Max: 25m 51s
  🟨 nvcc12.0           Pass:  80%/5   | Total:  1h 44m | Avg: 20m 49s | Max: 30m 02s | Hits: 435%/2476  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 02m | Avg: 31m 29s | Max: 32m 24s
  🟨 nvcc12.6           Pass:  92%/26  | Total: 11h 34m | Avg: 26m 42s | Max:  1h 04m | Hits: 440%/7609  
🟨 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  1h 18m | Avg: 19m 41s | Max: 23m 03s
  🟩 Clang15            Pass: 100%/1   | Total: 23m 40s | Avg: 23m 40s | Max: 23m 40s
  🟩 Clang16            Pass: 100%/1   | Total: 21m 25s | Avg: 21m 25s | Max: 21m 25s
  🟩 Clang17            Pass: 100%/1   | Total: 23m 19s | Avg: 23m 19s | Max: 23m 19s
  🟩 Clang18            Pass: 100%/8   | Total:  3h 21m | Avg: 25m 12s | Max:  1h 01m
  🟥 GCC7               Pass:   0%/2   | Total: 37m 17s | Avg: 18m 38s | Max: 19m 28s
  🟥 GCC8               Pass:   0%/1   | Total: 27m 21s | Avg: 27m 21s | Max: 27m 21s
  🟩 GCC9               Pass: 100%/2   | Total: 45m 07s | Avg: 22m 33s | Max: 25m 17s
  🟩 GCC10              Pass: 100%/1   | Total: 23m 29s | Avg: 23m 29s | Max: 23m 29s
  🟩 GCC11              Pass: 100%/1   | Total: 20m 40s | Avg: 20m 40s | Max: 20m 40s
  🟩 GCC12              Pass: 100%/1   | Total: 24m 58s | Avg: 24m 58s | Max: 24m 58s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 30m | Avg: 26m 18s | Max:  1h 04m
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 01m | Avg: 30m 31s | Max: 31m 01s | Hits: 426%/4962  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 14m | Avg: 37m 27s | Max: 41m 20s | Hits: 452%/5123  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 02m | Avg: 31m 29s | Max: 32m 24s
🟨 gpu
  🟨 v100               Pass:  91%/37  | Total: 15h 37m | Avg: 25m 19s | Max:  1h 04m | Hits: 439%/10085 
🟩 sm
  🟩 90                 Pass: 100%/1   | Total: 13m 02s | Avg: 13m 02s | Max: 13m 02s
  🟩 90a                Pass: 100%/2   | Total: 33m 22s | Avg: 16m 41s | Max: 16m 55s

🟩 cub: Pass: 100%/38 | Total: 1d 09h | Avg: 52m 17s | Max: 1h 08m | Hits: 38%/3528

🟩 cpu
  🟩 amd64              Pass: 100%/36  | Total:  1d 07h | Avg: 51m 51s | Max:  1h 08m | Hits:  38%/3528  
  🟩 arm64              Pass: 100%/2   | Total:  2h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  4h 58m | Avg: 59m 38s | Max:  1h 06m | Hits:  39%/882   
  🟩 12.5               Pass: 100%/2   | Total:  2h 16m | Avg:  1h 08m | Max:  1h 08m
  🟩 12.6               Pass: 100%/31  | Total:  1d 01h | Avg: 50m 04s | Max:  1h 07m | Hits:  38%/2646  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  2h 07m | Avg:  1h 03m | Max:  1h 06m
  🟩 nvcc12.0           Pass: 100%/5   | Total:  4h 58m | Avg: 59m 38s | Max:  1h 06m | Hits:  39%/882   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 16m | Avg:  1h 08m | Max:  1h 08m
  🟩 nvcc12.6           Pass: 100%/29  | Total: 23h 44m | Avg: 49m 06s | Max:  1h 07m | Hits:  38%/2646  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  2h 07m | Avg:  1h 03m | Max:  1h 06m
  🟩 nvcc               Pass: 100%/36  | Total:  1d 06h | Avg: 51m 38s | Max:  1h 08m | Hits:  38%/3528  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  3h 59m | Avg: 59m 52s | Max:  1h 05m
  🟩 Clang15            Pass: 100%/1   | Total:  1h 03m | Avg:  1h 03m | Max:  1h 03m
  🟩 Clang16            Pass: 100%/1   | Total: 59m 40s | Avg: 59m 40s | Max: 59m 40s
  🟩 Clang17            Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
  🟩 Clang18            Pass: 100%/7   | Total:  5h 44m | Avg: 49m 13s | Max:  1h 06m
  🟩 GCC7               Pass: 100%/2   | Total:  1h 57m | Avg: 58m 46s | Max: 59m 06s
  🟩 GCC8               Pass: 100%/1   | Total: 58m 48s | Avg: 58m 48s | Max: 58m 48s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 54m | Avg: 57m 18s | Max: 58m 14s
  🟩 GCC10              Pass: 100%/1   | Total: 58m 53s | Avg: 58m 53s | Max: 58m 53s
  🟩 GCC11              Pass: 100%/1   | Total: 58m 21s | Avg: 58m 21s | Max: 58m 21s
  🟩 GCC12              Pass: 100%/3   | Total:  1h 45m | Avg: 35m 19s | Max: 59m 16s
  🟩 GCC13              Pass: 100%/8   | Total:  5h 00m | Avg: 37m 33s | Max:  1h 04m
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 06m | Hits:  38%/1764  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 12m | Avg:  1h 06m | Max:  1h 07m | Hits:  39%/1764  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 16m | Avg:  1h 08m | Max:  1h 08m
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total: 12h 51m | Avg: 55m 08s | Max:  1h 06m
  🟩 GCC                Pass: 100%/18  | Total: 13h 34m | Avg: 45m 15s | Max:  1h 04m
  🟩 MSVC               Pass: 100%/4   | Total:  4h 24m | Avg:  1h 06m | Max:  1h 07m | Hits:  38%/3528  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 16m | Avg:  1h 08m | Max:  1h 08m
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 46m 41s | Avg: 23m 20s | Max: 27m 21s
  🟩 v100               Pass: 100%/36  | Total:  1d 08h | Avg: 53m 53s | Max:  1h 08m | Hits:  38%/3528  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total:  1d 06h | Avg: 59m 04s | Max:  1h 08m | Hits:  38%/3528  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 25m 32s | Avg: 25m 32s | Max: 25m 32s
  🟩 GraphCapture       Pass: 100%/1   | Total: 15m 29s | Avg: 15m 29s | Max: 15m 29s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 04m | Avg: 21m 34s | Max: 23m 56s
  🟩 TestGPU            Pass: 100%/2   | Total: 50m 02s | Avg: 25m 01s | Max: 28m 12s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 46m 41s | Avg: 23m 20s | Max: 27m 21s
  🟩 90a                Pass: 100%/1   | Total: 24m 55s | Avg: 24m 55s | Max: 24m 55s
🟩 std
  🟩 17                 Pass: 100%/14  | Total: 14h 10m | Avg:  1h 00m | Max:  1h 08m | Hits:  38%/2646  
  🟩 20                 Pass: 100%/24  | Total: 18h 56m | Avg: 47m 21s | Max:  1h 07m | Hits:  39%/882

🟩 thrust: Pass: 100%/37 | Total: 23h 14m | Avg: 37m 40s | Max: 1h 18m | Hits: 139%/9180

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 48m 57s | Avg: 24m 28s | Max: 31m 28s
🟩 cpu
  🟩 amd64              Pass: 100%/35  | Total: 22h 07m | Avg: 37m 56s | Max:  1h 18m | Hits: 139%/9180  
  🟩 arm64              Pass: 100%/2   | Total:  1h 06m | Avg: 33m 09s | Max: 34m 31s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 27m | Avg: 41m 24s | Max:  1h 03m | Hits:  68%/1836  
  🟩 12.5               Pass: 100%/2   | Total:  2h 32m | Avg:  1h 16m | Max:  1h 18m
  🟩 12.6               Pass: 100%/30  | Total: 17h 14m | Avg: 34m 29s | Max:  1h 10m | Hits: 156%/7344  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 09m | Avg: 34m 54s | Max: 36m 42s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 27m | Avg: 41m 24s | Max:  1h 03m | Hits:  68%/1836  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 32m | Avg:  1h 16m | Max:  1h 18m
  🟩 nvcc12.6           Pass: 100%/28  | Total: 16h 05m | Avg: 34m 28s | Max:  1h 10m | Hits: 156%/7344  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 09m | Avg: 34m 54s | Max: 36m 42s
  🟩 nvcc               Pass: 100%/35  | Total: 22h 04m | Avg: 37m 50s | Max:  1h 18m | Hits: 139%/9180  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 21m | Avg: 35m 24s | Max: 35m 39s
  🟩 Clang15            Pass: 100%/1   | Total: 36m 30s | Avg: 36m 30s | Max: 36m 30s
  🟩 Clang16            Pass: 100%/1   | Total: 36m 26s | Avg: 36m 26s | Max: 36m 26s
  🟩 Clang17            Pass: 100%/1   | Total: 34m 43s | Avg: 34m 43s | Max: 34m 43s
  🟩 Clang18            Pass: 100%/7   | Total:  3h 16m | Avg: 28m 02s | Max: 39m 12s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 10m | Avg: 35m 13s | Max: 35m 42s
  🟩 GCC8               Pass: 100%/1   | Total: 35m 29s | Avg: 35m 29s | Max: 35m 29s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 12m | Avg: 36m 19s | Max: 36m 24s
  🟩 GCC10              Pass: 100%/1   | Total: 37m 12s | Avg: 37m 12s | Max: 37m 12s
  🟩 GCC11              Pass: 100%/1   | Total: 35m 09s | Avg: 35m 09s | Max: 35m 09s
  🟩 GCC12              Pass: 100%/1   | Total: 39m 26s | Avg: 39m 26s | Max: 39m 26s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 27m | Avg: 25m 52s | Max: 40m 21s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 09m | Avg:  1h 04m | Max:  1h 05m | Hits:  89%/3672  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 49m | Avg: 56m 24s | Max:  1h 10m | Hits: 171%/5508  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 32m | Avg:  1h 16m | Max:  1h 18m
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total:  7h 25m | Avg: 31m 49s | Max: 39m 12s
  🟩 GCC                Pass: 100%/16  | Total:  8h 17m | Avg: 31m 05s | Max: 40m 21s
  🟩 MSVC               Pass: 100%/5   | Total:  4h 59m | Avg: 59m 48s | Max:  1h 10m | Hits: 139%/9180  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 32m | Avg:  1h 16m | Max:  1h 18m
🟩 gpu
  🟩 v100               Pass: 100%/37  | Total: 23h 14m | Avg: 37m 40s | Max:  1h 18m | Hits: 139%/9180  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total: 21h 38m | Avg: 41m 52s | Max:  1h 18m | Hits:  82%/7344  
  🟩 TestCPU            Pass: 100%/3   | Total: 48m 41s | Avg: 16m 13s | Max: 32m 55s | Hits: 365%/1836  
  🟩 TestGPU            Pass: 100%/3   | Total: 47m 14s | Avg: 15m 44s | Max: 17m 29s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total: 24m 35s | Avg: 24m 35s | Max: 24m 35s
🟩 std
  🟩 17                 Pass: 100%/14  | Total: 10h 29m | Avg: 44m 58s | Max:  1h 13m | Hits:  84%/5508  
  🟩 20                 Pass: 100%/21  | Total: 11h 55m | Avg: 34m 04s | Max:  1h 18m | Hits: 220%/3672

🟩 cudax: Pass: 100%/20 | Total: 4h 43m | Avg: 14m 10s | Max: 19m 47s | Hits: 129%/522

🟩 cpu
  🟩 amd64              Pass: 100%/16  | Total:  3h 49m | Avg: 14m 19s | Max: 19m 47s | Hits: 129%/522   
  🟩 arm64              Pass: 100%/4   | Total: 54m 23s | Avg: 13m 35s | Max: 14m 52s
🟩 ctk
  🟩 12.0               Pass: 100%/1   | Total:  9m 39s | Avg:  9m 39s | Max:  9m 39s | Hits: 126%/261   
  🟩 12.5               Pass: 100%/2   | Total: 19m 33s | Avg:  9m 46s | Max:  9m 56s
  🟩 12.6               Pass: 100%/17  | Total:  4h 14m | Avg: 14m 58s | Max: 19m 47s | Hits: 133%/261   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/1   | Total:  9m 39s | Avg:  9m 39s | Max:  9m 39s | Hits: 126%/261   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 19m 33s | Avg:  9m 46s | Max:  9m 56s
  🟩 nvcc12.6           Pass: 100%/17  | Total:  4h 14m | Avg: 14m 58s | Max: 19m 47s | Hits: 133%/261   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/20  | Total:  4h 43m | Avg: 14m 10s | Max: 19m 47s | Hits: 129%/522   
🟩 cxx
  🟩 Clang14            Pass: 100%/1   | Total: 15m 32s | Avg: 15m 32s | Max: 15m 32s
  🟩 Clang15            Pass: 100%/1   | Total: 14m 47s | Avg: 14m 47s | Max: 14m 47s
  🟩 Clang16            Pass: 100%/1   | Total: 17m 15s | Avg: 17m 15s | Max: 17m 15s
  🟩 Clang17            Pass: 100%/1   | Total: 15m 58s | Avg: 15m 58s | Max: 15m 58s
  🟩 Clang18            Pass: 100%/4   | Total:  1h 02m | Avg: 15m 34s | Max: 19m 47s
  🟩 GCC10              Pass: 100%/1   | Total: 15m 29s | Avg: 15m 29s | Max: 15m 29s
  🟩 GCC11              Pass: 100%/1   | Total: 15m 53s | Avg: 15m 53s | Max: 15m 53s
  🟩 GCC12              Pass: 100%/2   | Total: 35m 30s | Avg: 17m 45s | Max: 18m 36s
  🟩 GCC13              Pass: 100%/4   | Total: 50m 37s | Avg: 12m 39s | Max: 14m 52s
  🟩 MSVC14.36          Pass: 100%/1   | Total:  9m 39s | Avg:  9m 39s | Max:  9m 39s | Hits: 126%/261   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 11m 07s | Avg: 11m 07s | Max: 11m 07s | Hits: 133%/261   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 19m 33s | Avg:  9m 46s | Max:  9m 56s
🟩 cxx_family
  🟩 Clang              Pass: 100%/8   | Total:  2h 05m | Avg: 15m 43s | Max: 19m 47s
  🟩 GCC                Pass: 100%/8   | Total:  1h 57m | Avg: 14m 41s | Max: 18m 36s
  🟩 MSVC               Pass: 100%/2   | Total: 20m 46s | Avg: 10m 23s | Max: 11m 07s | Hits: 129%/522   
  🟩 NVHPC              Pass: 100%/2   | Total: 19m 33s | Avg:  9m 46s | Max:  9m 56s
🟩 gpu
  🟩 v100               Pass: 100%/20  | Total:  4h 43m | Avg: 14m 10s | Max: 19m 47s | Hits: 129%/522   
🟩 jobs
  🟩 Build              Pass: 100%/18  | Total:  4h 06m | Avg: 13m 43s | Max: 18m 36s | Hits: 129%/522   
  🟩 Test               Pass: 100%/2   | Total: 36m 41s | Avg: 18m 20s | Max: 19m 47s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total: 10m 22s | Avg: 10m 22s | Max: 10m 22s
  🟩 90a                Pass: 100%/1   | Total: 12m 36s | Avg: 12m 36s | Max: 12m 36s
🟩 std
  🟩 17                 Pass: 100%/4   | Total: 46m 03s | Avg: 11m 30s | Max: 12m 58s
  🟩 20                 Pass: 100%/16  | Total:  3h 57m | Avg: 14m 50s | Max: 19m 47s | Hits: 129%/522

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 12m 40s | Avg: 6m 20s | Max: 10m 28s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 12m 40s | Avg:  6m 20s | Max: 10m 28s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 12m 40s | Avg:  6m 20s | Max: 10m 28s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 12m 40s | Avg:  6m 20s | Max: 10m 28s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 12m 40s | Avg:  6m 20s | Max: 10m 28s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 12m 40s | Avg:  6m 20s | Max: 10m 28s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 12m 40s | Avg:  6m 20s | Max: 10m 28s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 12m 40s | Avg:  6m 20s | Max: 10m 28s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 12s | Avg:  2m 12s | Max:  2m 12s
  🟩 Test               Pass: 100%/1   | Total: 10m 28s | Avg: 10m 28s | Max: 10m 28s

🟩 python: Pass: 100%/1 | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
+/-	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 135)

#	Runner
92	`linux-amd64-cpu16`
17	`linux-amd64-gpu-v100-latest-1`
15	`windows-amd64-cpu16`
10	`linux-arm64-cpu16`
1	`linux-amd64-gpu-h100-latest-1-testing`

davebayer requested review from a team as code owners January 22, 2025 17:46

davebayer requested review from wmaxey and leofang January 22, 2025 17:46

davebayer requested a review from elstehle January 22, 2025 17:46

davebayer force-pushed the refactor_cstring branch 2 times, most recently from 224a155 to 3793a2d Compare January 22, 2025 17:51

davebayer requested a review from a team as a code owner January 22, 2025 18:55

davebayer requested a review from gonidelis January 22, 2025 18:55

miscco approved these changes Jan 23, 2025

View reviewed changes

libcudacxx/include/cuda/std/detail/libcxx/include/cstring Show resolved Hide resolved

davebayer force-pushed the refactor_cstring branch 2 times, most recently from 694c525 to e0a7902 Compare January 23, 2025 09:02

refactor <cuda/std/cstring>

412c2a3

davebayer force-pushed the refactor_cstring branch from e0a7902 to 412c2a3 Compare January 23, 2025 09:09

replace __atomic_memcmp with cuda::std::memcmp

af4195b

miscco requested changes Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor `<cuda/std/cstring>` #3484

Refactor `<cuda/std/cstring>` #3484

davebayer commented Jan 22, 2025 •

edited

Loading

copy-pr-bot bot commented Jan 22, 2025

miscco commented Jan 23, 2025

miscco Jan 23, 2025

github-actions bot commented Jan 23, 2025

🟨 libcudacxx: Pass: 91%/37 | Total: 15h 37m | Avg: 25m 19s | Max: 1h 04m | Hits: 439%/10085

🟩 cub: Pass: 100%/38 | Total: 1d 09h | Avg: 52m 17s | Max: 1h 08m | Hits: 38%/3528

🟩 thrust: Pass: 100%/37 | Total: 23h 14m | Avg: 37m 40s | Max: 1h 18m | Hits: 139%/9180

🟩 cudax: Pass: 100%/20 | Total: 4h 43m | Avg: 14m 10s | Max: 19m 47s | Hits: 129%/522

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 12m 40s | Avg: 6m 20s | Max: 10m 28s

🟩 python: Pass: 100%/1 | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 135)

Refactor <cuda/std/cstring> #3484

Are you sure you want to change the base?

Refactor <cuda/std/cstring> #3484

Conversation

davebayer commented Jan 22, 2025 • edited Loading

copy-pr-bot bot commented Jan 22, 2025

miscco commented Jan 23, 2025

miscco Jan 23, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 23, 2025

🟨 libcudacxx: Pass: 91%/37 | Total: 15h 37m | Avg: 25m 19s | Max: 1h 04m | Hits: 439%/10085

🟩 cub: Pass: 100%/38 | Total: 1d 09h | Avg: 52m 17s | Max: 1h 08m | Hits: 38%/3528

🟩 thrust: Pass: 100%/37 | Total: 23h 14m | Avg: 37m 40s | Max: 1h 18m | Hits: 139%/9180

🟩 cudax: Pass: 100%/20 | Total: 4h 43m | Avg: 14m 10s | Max: 19m 47s | Hits: 129%/522

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 12m 40s | Avg: 6m 20s | Max: 10m 28s

🟩 python: Pass: 100%/1 | Total: 43m 38s | Avg: 43m 38s | Max: 43m 38s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 135)

Refactor `<cuda/std/cstring>` #3484

Refactor `<cuda/std/cstring>` #3484

davebayer commented Jan 22, 2025 •

edited

Loading