Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vtk and pv dependencies optional for DoMINO #761

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Make vtk and pv dependencies optional for DoMINO #761

merged 2 commits into from
Jan 14, 2025

Conversation

mnabian
Copy link
Collaborator

@mnabian mnabian commented Jan 14, 2025 •
edited
Loading

Modulus Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@mnabian
Copy link
Collaborator Author

mnabian commented Jan 14, 2025

/blossom-ci

@mnabian mnabian self-assigned this Jan 14, 2025
@RishikeshRanade
Copy link
Collaborator

LGTM

@mnabian mnabian merged commit 22e6dd3 into NVIDIA:main Jan 14, 2025
1 check passed
@mnabian mnabian deleted the bug-ext-pv_domino branch January 14, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RishikeshRanade RishikeshRanade RishikeshRanade approved these changes

Assignees

@mnabian mnabian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnabian @RishikeshRanade