Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to experiment-based Hydra config in L-MGN example #771

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Move to experiment-based Hydra config in L-MGN example #771

wants to merge 4 commits into from

Conversation

Alexey-Kamenev
Copy link
Collaborator

@Alexey-Kamenev Alexey-Kamenev commented Jan 28, 2025 •
edited
Loading

Modulus Pull Request

Description

  • moved to Hydra experiment config which simplifies configuring different dataset experiments in L-MGN.
  • The example now supports 15+ datasets that are used in the original paper.
  • Unified training and inference script configuration which are now both experiment-driven which guarantees coherency.
  • Refactored logging since W&B is not available anymore.

Results on different datasets:

  • Water:
  • Water 3D:
  • Sand:
  • Water ramps:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@Alexey-Kamenev Alexey-Kamenev added the 2 - In Progress Currently a work in progress label Jan 28, 2025
@Alexey-Kamenev Alexey-Kamenev self-assigned this Jan 28, 2025
@Alexey-Kamenev
Copy link
Collaborator Author

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

/blossom-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktangsali ktangsali Awaiting requested review from ktangsali

At least 1 approving review is required to merge this pull request.

Assignees

@Alexey-Kamenev Alexey-Kamenev

Labels
2 - In Progress Currently a work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Alexey-Kamenev