Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm that it's safe to remove lnrpc.SignMessage #10

Open
aakselrod opened this issue May 11, 2023 · 0 comments
Open

Confirm that it's safe to remove lnrpc.SignMessage #10

aakselrod opened this issue May 11, 2023 · 0 comments

Comments

@aakselrod
Copy link
Member

Current integration tests show that lnrpc.SignMessage in lndsigner is currently unused, even when calling the same RPC in lnd (because lnd uses the signrpc version of the call under the hood). We should confirm that there's no code path in lnd that can call this RPC and then remove it to reduce unused code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aakselrod