Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver-git gives proper version on dirty working tree #18

Open
deepy opened this issue Jul 10, 2018 · 1 comment
Open

semver-git gives proper version on dirty working tree #18

deepy opened this issue Jul 10, 2018 · 1 comment
Labels

Comments

@deepy
Copy link
Member

deepy commented Jul 10, 2018

If we have a tagged version and a dirty working tree, semver-git gives us the tagged version.

The expected result is probably rather a SNAPSHOT.

@deepy deepy added the bug label Jul 10, 2018
@emlun
Copy link

emlun commented Jan 31, 2023

This is because the dirty marker is only added if a there is a <dirty> placeholder in ext.snapshotSuffix, which by default is just SNAPSHOT.

I agree this is unexpected, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants