From 27b6968fc9a22075f36e5253bec342a9173846c5 Mon Sep 17 00:00:00 2001 From: wojciechos Date: Tue, 14 Jan 2025 23:43:42 +0700 Subject: [PATCH] Skip tests BlockWithReceipts due to invalid test asserts (#2374) The test expects transaction_hash in the transaction object, but according to the spec, it's only required under receipt. --- .github/workflows/starknet-go-tests.yml | 2 +- .github/workflows/starknet-rs-tests.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/starknet-go-tests.yml b/.github/workflows/starknet-go-tests.yml index 7d81979047..1f6a2ddaac 100644 --- a/.github/workflows/starknet-go-tests.yml +++ b/.github/workflows/starknet-go-tests.yml @@ -31,6 +31,6 @@ jobs: run: go mod download - name: Test RPC on testnet - run: cd rpc && go test -timeout 1200s -v -env testnet . + run: cd rpc && go test -skip 'TestBlockWithReceipts' -timeout 1200s -v -env testnet . env: INTEGRATION_BASE: ${{ secrets.TEST_RPC_URL }} diff --git a/.github/workflows/starknet-rs-tests.yml b/.github/workflows/starknet-rs-tests.yml index e70e9ccc55..ea933403a1 100644 --- a/.github/workflows/starknet-rs-tests.yml +++ b/.github/workflows/starknet-rs-tests.yml @@ -26,7 +26,7 @@ jobs: - name: Run jsonrpc tests run: | cd starknet-providers && cargo test jsonrpc - cd ../starknet-accounts && cargo test jsonrpc -- --skip can_declare_cairo0_contract_with_jsonrpc + cd ../starknet-accounts && cargo test jsonrpc -- --skip can_declare_cairo0_contract_with_jsonrpc --skip jsonrpc_get_block_with_receipts env: STARKNET_RPC: ${{ secrets.STARKNET_RPC }} RUST_BACKTRACE: full