From c1e9e58d0dd2a3bf898045ca1789543e3ed29611 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=96mer=20Faruk=20IRMAK?= Date: Fri, 1 Dec 2023 19:02:00 +0300 Subject: [PATCH] Fix potential nil panic in LegacyTraceTransaction --- rpc/handlers.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rpc/handlers.go b/rpc/handlers.go index d7f1628072..39f9f5a911 100644 --- a/rpc/handlers.go +++ b/rpc/handlers.go @@ -1354,7 +1354,7 @@ func (h *Handler) TraceTransaction(ctx context.Context, hash felt.Felt) (json.Ra // https://github.com/starkware-libs/starknet-specs/blob/1ae810e0137cc5d175ace4554892a4f43052be56/api/starknet_trace_api_openrpc.json#L11 func (h *Handler) LegacyTraceTransaction(ctx context.Context, hash felt.Felt) (json.RawMessage, *jsonrpc.Error) { trace, err := h.traceTransaction(ctx, &hash, true) - if err.Code == ErrTxnHashNotFound.Code { + if err != nil && err.Code == ErrTxnHashNotFound.Code { err = ErrInvalidTxHash } return trace, err