Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move responsibility for proper handling different versions of format to ZipLoaders or other dedicated classes. #6

Open
abukaj opened this issue Oct 10, 2018 · 0 comments

Comments

@abukaj
Copy link
Member

abukaj commented Oct 10, 2018

def _fromZipCSV(self, zf, path, source=None, oldLabels=None):

uses
_convertZip = {'Animals': {#'Tag': int,

dictionary to convert columns of CSV files to appropriate type. As names of columns differ with versions - that makes format handling a responsibility of the Loader.

In the development branches there are further examples of such responsibility, like:
https://github.com/Neuroinflab/PyMICE/blob/format_version_2/lib/pymice/_ICData.py#L322

abukaj added a commit that referenced this issue Dec 20, 2018
Methods of ZipLoaders renamed to match keys in `Data._objectBases` dictionary:
- `.loadHw()` -> `.loadHardwareEvents()`,
- `.loadEnv()` -> `.loadEnvironment()`.
abukaj added a commit that referenced this issue Dec 21, 2018
Their full implementation is necessary to resolve issue #6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant