Cannot disable/delete mod installed by fomod wizard

[jaredmcateer]

Bug Report

Summary

NexusMods.App is not cleaning up some mod files that were generated by a Vortex installed mod. When the mod is disabled, or completely deleted, the mod files will still be regenerated when launching the game from the NexusMods.App.

Steps to reproduce

1. Install the Vortex version of Better Minimap
2. Choose any of the options the wizard presents.
   • Notice that there are no changes to apply when finished installing
3. Launch the game
4. Exit the game
   • 3 & 4 may be optional but I kept them in for completeness.
5. Toggle off (or delete) Better Minimap
   • Notice again that there are no changes to be applied
6. Open <...>/steamapps/common/Cyberpunk 2077/archive/pc/mod
   • Notice WillyJL_BetterMinimap_*.archive is still present
7. Delete (or rename) WillyJL_BetterMinimap_*.archive
   • If you chose DistanceFix you will also have to delete <root>/steamapps/common/Cyberpunk 2077/engine/config/platform/pc/WillyJL_BetterMinimap_DistanceFix.ini
8. From NexusMod.app press play
   • Notice WillyJL_BetterMinimap_*.archive has reappeared
   • If you chose Distance fix WillyJL_BetterMinimap_DistanceFix.ini will also reappear

What is the expected behaviour?

Toggling off or Deleting the mod should remove the file and not regenerate it when starting the game from the app.

If this is due to a misconfiguration of the mod itself there should still be some way of cleaning up orphaned mods from the App when a FOMOD has been removed and not have them reappear on subsequent plays.

Other information

Tip

Starting the game from steam/cli does not regenerate the mod files. This is the workaround to avoid having mod files reappear.

Caution

Re-running the FOMOD wizard, by re-installing the mod, with different settings will generate multiple version of the mod

Logs

nexusmods.app.main.current.log
nexusmods.app.slim.current.log

System Info

OS: Pop!_OS 22.04 LTS x86_64
Kernel: 6.9.3-76060903-generic
DE: GNOME 42.9
CPU: 13th Gen Intel i5-13600K (20) @ 5.100GHz
GPU: Intel Device a780
GPU: NVIDIA 01:00.0 NVIDIA Corporation Device 2782

[Pickysaurus]

Thanks for the report, I am first going to try and replicate it on Windows.

1. Downloading https://www.nexusmods.com/Core/Libs/Common/Widgets/DownloadPopUp?id=21973&nmm=1&game_id=3333
2. Make no change to the default options in the FOMOD.
3. The app wants to apply one file to the game folder.
4. Launch and close the game (I did not load a save)
5. Disable Better Minimap in My Mods
6. There is no prompt to apply changes

00:05:55.443 [INFO] (NexusMods.Abstractions.Games.RunGameTool) Finished running C:/Games/Epic/Cyberpunk2077/bin/x64/Cyberpunk2077.exe
00:05:55.443 [INFO] (NexusMods.DataModel.ToolManager) Ingesting loadout EId:20000000000236E from Cyberpunk 2077 2.2
00:05:55.582 [DEBUG] (NexusMods.MnemonicDB.Storage.DatomStore) Transaction Tx:100000000000349 post-processed in 0ms
00:05:55.582 [DEBUG] (NexusMods.Abstractions.Loadouts.Synchronizers.ALoadoutSynchronizer) Backing up 1 files
00:05:55.582 [DEBUG] (NexusMods.DataModel.NxFileStore) Backing up 1 files of 86.354 KB in size
00:05:55.641 [DEBUG] (NexusMods.MnemonicDB.Storage.DatomStore) Transaction Tx:10000000000034A post-processed in 0ms
00:05:55.641 [DEBUG] (NexusMods.Abstractions.Loadouts.Synchronizers.ALoadoutSynchronizer) Ingesting 1 files
00:05:55.641 [DEBUG] (NexusMods.Abstractions.Loadouts.Synchronizers.ALoadoutSynchronizer) Extracting 1 files to disk
00:05:55.641 [DEBUG] (NexusMods.MnemonicDB.Storage.DatomStore) Transaction Tx:10000000000034B post-processed in 0ms
00:06:00.167 [INFO] (System.Net.Http.HttpClient.OtlpMetricExporter.LogicalHandler) Start processing HTTP request POST https://collector.nexusmods.com/v1/metrics
00:06:00.167 [INFO] (System.Net.Http.HttpClient.OtlpMetricExporter.ClientHandler) Sending HTTP request POST https://collector.nexusmods.com/v1/metrics
00:06:00.240 [INFO] (System.Net.Http.HttpClient.OtlpMetricExporter.ClientHandler) Received HTTP response headers after 72.3678ms - 200
00:06:00.240 [INFO] (System.Net.Http.HttpClient.OtlpMetricExporter.LogicalHandler) End processing HTTP request after 72.9397ms - 200
00:06:00.322 [DEBUG] (Microsoft.Extensions.Http.DefaultHttpClientFactory) Starting HttpMessageHandler cleanup cycle with 3 items
00:06:00.322 [DEBUG] (Microsoft.Extensions.Http.DefaultHttpClientFactory) Ending HttpMessageHandler cleanup cycle after 0.0982ms - processed: 1 items - remaining: 2 items
00:06:10.328 [DEBUG] (Microsoft.Extensions.Http.DefaultHttpClientFactory) Starting HttpMessageHandler cleanup cycle with 2 items
00:06:10.328 [DEBUG] (Microsoft.Extensions.Http.DefaultHttpClientFactory) Ending HttpMessageHandler cleanup cycle after 0.0021ms - processed: 0 items - remaining: 2 items
00:06:18.609 [DEBUG] (NexusMods.App.UI.InjectedViewLocator) Finding View for NexusMods.App.UI.Pages.LoadoutPage.LoadoutViewModel
00:06:18.609 [INFO] (Avalonia.ReactiveUI.ViewModelViewHost) Ready to show NexusMods.App.UI.Pages.LoadoutPage.LoadoutView with autowired NexusMods.App.UI.Pages.LoadoutPage.LoadoutViewModel.
00:06:19.624 [DEBUG] (NexusMods.DataModel.Synchronizer.SynchronizerService) Checking for changes in loadout LoadoutId:20000000000236e
00:06:19.624 [DEBUG] (NexusMods.MnemonicDB.Storage.DatomStore) Transaction Tx:10000000000034C post-processed in 1ms
00:06:19.624 [DEBUG] (NexusMods.DataModel.Synchronizer.SynchronizerService) Changes found in loadout LoadoutId:20000000000236e: False

Seems the file was ingested by the app as an external change rather than being treated as a mod file. This is definitely a bug.

nexusmods.app.main.current.log

[Pickysaurus]

This appears to be a bug related to the mod using a FOMOD installer, but I don't know of any mods off-hand that use it so I can't test it.