Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The testsuite never checks what happens when destStore != localStore #938

Closed
thufschmitt opened this issue Apr 28, 2021 · 2 comments · Fixed by #940
Closed

The testsuite never checks what happens when destStore != localStore #938

thufschmitt opened this issue Apr 28, 2021 · 2 comments · Fixed by #940

Comments

@thufschmitt
Copy link
Member

Hydra distinguishes between the “local store” (the one on which the evaluation takes place) and the “destination store” (the one to which all the build outputs are sent). However in the test suite both these stores are the same one, which might hide some logic errors (caused me some surprise in #875 for example).

This could be fixed for example by setting store_uri = file:/some/where in the hydra config used for the tests.

thufschmitt added a commit to thufschmitt/hydra that referenced this issue Apr 28, 2021
Set `dest_store` in the test hydra config, so that the testsuite ensures
that the distinction between the local store and the destination store
is properly taken into account.

Fix NixOS#938
@grahamc
Copy link
Member

grahamc commented Apr 28, 2021 via email

@thufschmitt
Copy link
Member Author

It would be great if you could submit such a test!

Just in case you missed it, the PR is already there (#940), but it's stuck atm because it breaks a test and I'm not sure how to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants