password archivable

[wendy0402]

Hi, what do you think about feature archiving password? It will prevent a user to change password with one of the last x(from config) of old password. Actually it kinda like from devise_security_extension. It can be useful for security purpose.
thanks.

[arnvald]

There is a PR that adds it, in my comment there I explain that probably it should become a plugin to Sorcery instead of another core module: #535

If someone would like to start working on plugins for Sorcery, I'll be very happy to help and to discuss what API should Sorcery have to make it work well plugins.

[wendy0402]

make it into plugin would be a good idea. I'm still a novice in ruby, but I guess I have enough free time try to make it, how about it? 😄

[arnvald]

Sure! Let me know whenever you are stuck - I'll try to help

[wendy0402]

Hi, I already make it. But it is still far from perfect, would you mind to check it? sorcery_wand. If you see several code that is quite familiar, maybe because i take several ideas from sorcery to the gem. Please review it if you can, thanks

[arnvald]

Hi @wendy0402
I'm sorry for late reply, I haven't had any time recently to work on Sorcery. I'll check your gem's code next week!

[arnvald]

@wendy0402 thanks once again for writing your gem! The code looks fine, although I haven't run it in any app yet. Are you using it in some application? I was wondering if the commented code in engine does not prevent it from running correctly?

I already have some ideas how to make Sorcery more plugin-friendly, so that instead of writing the whole gem with handling configuration and ORMs etc. you could write only the classes containing submodules and generators and the rest would be handled by Sorcery. I'll use your gem to test it and I hope late this year I'll have ready version, so that your gem can be simplified 😃

[wendy0402]

@arnvald about the code in engine gives me problem. I don't remember clearly but I guess there is problem when I tried to do migration for password_archive. Rails will run all of the rails engine before migrate it. There haven't any password_archive table at the boot time, meanwhile the submodule call the model password_archive. It cause error then.
I haven't use my gem in any production application for now. Just test it in simple app.
Great, I can't wait for it. Do you think I should wait for you, if I want to add more submodules? 😄