Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardfork validation needs to be adapted when we make chain types extensible #6180

Open
schaable opened this issue Jan 23, 2025 · 1 comment
Open

Hardfork validation needs to be adapted when we make chain types extensible #6180

schaable opened this issue Jan 23, 2025 · 1 comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone
Public Alpha Feat...

Comments

@schaable
Copy link
Member

Current behavior: the hardfork value in the user config is validated by Zod as a value in the HardforkName enum. However, this validation is only appropriate for the l1 chain type.

Expected behavior: the hardfork validation should either be based on the chainType or skipped entirely.
@schaable schaable added the v-next A Hardhat v3 development task label Jan 23, 2025
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 23, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jan 23, 2025
@schaable schaable mentioned this issue Jan 23, 2025
Open
@schaable
Copy link
Member Author

This issue should take the overrides into account.

@kanej kanej added this to the Public Alpha Feature Rollout milestone Jan 23, 2025
@kanej kanej moved this from Backlog to To-do in Hardhat Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: To-do
Milestone
Public Alpha Feature Rollout
Development

No branches or pull requests
2 participants
@kanej @schaable