Feat/questions supabase #4053

mariojsnunes · 2024-12-28T17:29:44Z

PR Checklist

- Commit messages are descriptive, it will be used in our Release Notes
- Unit and e2e tests for the changes that have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Refactoring (no functional changes)

What is the current behavior?

Questions are stored in firebase.

What is the new behavior?

Questions are stored in supabase.
Also migrated:

tags
useful
follow (subscribers)

Question images are also saved in supabase storage.
Removed moderation code for questions (wasn't being used in the UI)

TODO:

can we have a custom supabase cdn url? (so we don't expose the supabase url)
document storage migration/setup
data migration

Does this PR introduce a breaking change?

Yes
No

Git Issues

Closes #4059 and #3918

fix: build;

benfurber · 2025-01-06T09:49:25Z

Niiiice, I'll have a look today.

cypress · 2025-01-09T20:53:41Z

onearmy-community-platform Run #6778

Run Properties: Failed #6778 • 7cd2a34987: Merge branch 'master' into feat/questions-supabase

Project	`onearmy-community-platform`
Branch Review	`feat/questions-supabase`
Run status	`Failed #6778`
Run duration	`05m 58s`
Commit	`7cd2a34987: Merge branch 'master' into feat/questions-supabase`
Committer	`Mário Nunes`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`3`
Pending	`0`
Skipped	`0`
Passing	`77`
View all changes introduced in this branch ↗︎

Tests for review

src/integration/notifications.spec.ts • 1 failed test • ci-chrome

View Output Video

Test		Artifacts
[Notifications] > [are generated by clicking on useful for projects]		`Test Replay` `Screenshots` `Video`

notifications.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
[Notifications] > [are generated by clicking on useful for research]		`Test Replay` `Screenshots` `Video`

library/read.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
... > [Delete Button is disabled]		`Test Replay` `Screenshots` `Video`

research/follow.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
[Research] > [By Authenticated] > [Follow button]		`Test Replay` `Screenshots` `Video`

docs: add cypress docs;

fix: question slug unique constraint must consider tenant_id;

codecov · 2025-01-13T11:01:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@cde2fc3). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #4053   +/-   ##
=========================================
  Coverage          ?   69.66%           
=========================================
  Files             ?       39           
  Lines             ?     1236           
  Branches          ?      258           
=========================================
  Hits              ?      861           
  Misses            ?      353           
  Partials          ?       22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benfurber

Coool! Really clear direction will all of this. Nice one.

Left a bunch of comments, obvs. Big thing from me I think is what would be unit tested out of all this, there's lots of key system behaviour here.

packages/cypress/src/integration/questions/search.spec.ts

packages/cypress/src/integration/questions/read.spec.ts

packages/cypress/src/integration/questions/discussions.spec.ts

packages/cypress/src/integration/questions/read.spec.ts

shared/mocks/data/categories.ts

src/routes/api.subscribers.$contentType.$contentId.ts

src/services/questionService.ts

vite.config.ts.timestamp-1736550923998-a30767ea98555.mjs

benfurber

I think we're still missing a unit testing approach but not essential for this PR.

packages/cypress/src/integration/questions/read.spec.ts

shared/mocks/data/categories.ts

src/common/Form/TagsSelectFieldV2.tsx

mariojsnunes added 6 commits December 10, 2024 12:22

chore: add tenant_id to cypress environment

e02543f

chore: seed database

1d508aa

wip questions

4df42f0

wip questions

e3d8b6a

Merge branch 'master' into feat/questions-supabase

eb170c5

feat: questions supabase

69912aa

mariojsnunes requested a review from a team as a code owner December 28, 2024 17:29

github-actions bot added the Mod: HowTo 📰 label Dec 28, 2024

mariojsnunes added 2 commits December 29, 2024 12:20

fix: discussions with supabase questions

ee6c71d

fix: notifications with supabase questions;

e58c5f8

fix: build;

github-actions bot added the Mod: Research 🔬 label Dec 29, 2024

mariojsnunes added 3 commits January 3, 2025 00:56

feat: image public url and transforms

09139cd

fix: questions list

9790968

merge

0469958

mariojsnunes added 5 commits January 6, 2025 10:48

feat: added sort by comments

c8c306a

fix import

f42a0a3

questions migration script

d73ce48

Merge branch 'master' into feat/questions-supabase

758b146

merge

cee0ed1

github-actions bot added the Mod: Library 📰 label Jan 9, 2025

mariojsnunes added 3 commits January 9, 2025 20:07

remove guidance for files

9a5f00a

remove question store

3b78489

remove question store

27037b2

mariojsnunes added 5 commits January 9, 2025 21:20

feat: duplicate question validation and error message

35390e5

fix: spec for file category guidance

43ae242

Merge branch 'chore/comments-v2-tests' into feat/questions-supabase

a9cfe8f

chore: updated cypress tests with supabase

9beeb20

chore: update migration script;

476f89c

docs: add cypress docs;

mariojsnunes added 6 commits January 10, 2025 18:41

fix

f71fc3d

remove unique check

c08417e

chore: fix tests to work with supabase;

2491f44

fix: question slug unique constraint must consider tenant_id;

fix: edit question submit button

56e8293

fix

be11d96

fix: library category

f38567c

mariojsnunes added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jan 11, 2025

mariojsnunes had a problem deploying to preview January 11, 2025 18:57 — with GitHub Actions Failure

mariojsnunes temporarily deployed to preview January 11, 2025 19:16 — with GitHub Actions Inactive

mariojsnunes mentioned this pull request Jan 12, 2025

chore: rename all library functions #4073

Draft

12 tasks

fix: disable image transform

7166865

mariojsnunes temporarily deployed to preview January 13, 2025 10:50 — with GitHub Actions Inactive

re-add image transforms

88dcbd6

mariojsnunes temporarily deployed to preview January 13, 2025 18:11 — with GitHub Actions Inactive

benfurber reviewed Jan 14, 2025

View reviewed changes

mariojsnunes added 2 commits January 15, 2025 23:10

cleanup

be13a31

chore: add reply read test

0c63d87

mariojsnunes had a problem deploying to preview January 15, 2025 23:18 — with GitHub Actions Failure

mariojsnunes had a problem deploying to preview January 15, 2025 23:40 — with GitHub Actions Failure

benfurber approved these changes Jan 16, 2025

View reviewed changes

packages/cypress/src/integration/questions/read.spec.ts Show resolved Hide resolved

shared/mocks/data/categories.ts Show resolved Hide resolved

src/common/Form/TagsSelectFieldV2.tsx Outdated Show resolved Hide resolved

Merge branch 'master' into feat/questions-supabase

2bdbd86

mariojsnunes had a problem deploying to preview January 16, 2025 17:16 — with GitHub Actions Failure

Merge branch 'master' into feat/questions-supabase

c0e93ae

mariojsnunes temporarily deployed to preview January 16, 2025 20:54 — with GitHub Actions Inactive

Merge branch 'master' into feat/questions-supabase

7cd2a34

mariojsnunes deployed to preview January 17, 2025 13:17 — with GitHub Actions View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/questions supabase #4053

Feat/questions supabase #4053

mariojsnunes commented Dec 28, 2024 •

edited

Loading

benfurber commented Jan 6, 2025

cypress bot commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

benfurber left a comment

benfurber left a comment

Feat/questions supabase #4053

Are you sure you want to change the base?

Feat/questions supabase #4053

Conversation

mariojsnunes commented Dec 28, 2024 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Git Issues

benfurber commented Jan 6, 2025

cypress bot commented Jan 9, 2025 • edited Loading

onearmy-community-platform Run #6778

Tests for review

codecov bot commented Jan 13, 2025 • edited Loading

Codecov Report

benfurber left a comment

Choose a reason for hiding this comment

benfurber left a comment

Choose a reason for hiding this comment

mariojsnunes commented Dec 28, 2024 •

edited

Loading

cypress bot commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading