Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer in Hardox #29

Open
urpylka opened this issue Apr 19, 2021 · 4 comments
Open

Spacer in Hardox #29

urpylka opened this issue Apr 19, 2021 · 4 comments

Comments

@urpylka
Copy link

urpylka commented Apr 19, 2021

Please check location of the SHRPRO-V1 1120.14-A Spacer 4mm. Now it is in folder Hardox_4mm. But it should be placed in Steel 4mm folder (check the blueprint).

@darigovresearch
Copy link
Contributor

Can any of the maintainers advise on this?

Not sure which one is correct.

@urpylka could you provide more context to what the issue is to help the maintainers resolve the issue?

Is it just that the spacer file should be moved from one folder to the other?

If so this may be a good first issue to make a pull request, that way all the maintainers need to do is to click one button to make the correction.

@urpylka
Copy link
Author

urpylka commented May 31, 2021

Yes, I suggest to move file to another folder. I opened this issue to get feedback about that from maintainers. I've got answer in Discord (see image).

I can make PR if it will be accepted.

photo_2021-05-31 21 52 26

@darigovresearch
Copy link
Contributor

Thanks for the clarification, you're welcome to put in a pull request but as we don't have privileges on the repository can't guarantee that it will be merged.

However there is only one way to find out if it will be merged and that is making a pull request

@darigovresearch
Copy link
Contributor

Merging pull request #30 should resolve this issue, thanks for making the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants