Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all boost::shared_ptr to std #10

Open
anyfilatov opened this issue Apr 27, 2018 · 1 comment
Open

Change all boost::shared_ptr to std #10

anyfilatov opened this issue Apr 27, 2018 · 1 comment

Comments

@anyfilatov
Copy link

anyfilatov commented Apr 27, 2018

std::queue<boost::shared_ptr<MsgType>> _msg_cache;

@HatlessFox
Copy link
Collaborator

HatlessFox commented May 18, 2018

We are unable to rule out boost::shared_ptr entirely from the source code since rosbag::MessageInstance::instantiate returns it. We can copy the content of the boost::s_ptr to an std::s_ptr and put it to _msg_cache but I don't see any benefit of this action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants