Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template skill #36

Open
JarbasAl opened this issue Feb 13, 2023 · 1 comment
Open

template skill #36

JarbasAl opened this issue Feb 13, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JarbasAl
Copy link
Contributor

bring up https://github.com/OpenVoiceOS/skill-template-repo to latest best practices

  • general review
  • unittest examples from our docs
  • updated imports
  • more user friendly readme
  • perhaps helper command line tool msk style to handle all string replacement mentioned in readme

add it to docs
@JarbasAl JarbasAl added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 13, 2023
@JarbasAl JarbasAl mentioned this issue Feb 13, 2023
Closed
@mikejgray
Copy link
Contributor

@JarbasAl The last bullet point is handled by https://github.com/mikejgray/ovos-skill-projen , and all of the recommendations you have here could be added there as well. A template repo isn't a bad idea - a lot of people prefer those - but maybe we could move skill-template-repo to projen management, which would help force us to keep both repos in alignment with current best practices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikejgray @JarbasAl