Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse cluster names to be alphanumeric only #224

Closed
2 tasks
boulder225 opened this issue Oct 27, 2023 · 1 comment
Closed
2 tasks

Parse cluster names to be alphanumeric only #224

boulder225 opened this issue Oct 27, 2023 · 1 comment
Labels
protocol protocol team tickets streamline

Comments

@boulder225
Copy link

🎯 Problem to be solved

Grafana is breaking due to clusters having special characters in their names. This is particularly problematic as it affects monitoring and visualization. After a first analysis, cluster names can have special characters in names:

charon create cluster --name="This is a string with special characters: \n (newline), \t (tab), \\ (backslash), \" (double quote), and \x41 (hex escape for 'A')." --withdrawal-addresses="0xC0404ed740a69d11201f5eD297c5732F562c6E4e" --fee-recipient-addresses="0xC0404ed740a69d11201f5eD297c5732F562c6E4e" --nodes=4 --threshold=3 --network=holesky --num-validators=5

🛠️ Proposed solution

  • Update validation rules for cluster name creation to restrict special characters.
  • Update documentation to reflect the new naming constraints.
@github-actions github-actions bot added the protocol protocol team tickets label Oct 27, 2023
@OisinKyne
Copy link
Contributor

Can we be a bit more flexible than only alphanumeric? I'd maybe do it by blacklisting things, e.g. whitespaces and quotations and stuff. Would be nice if we could be a little multi-lingual friendly, but if not, not the end of the world. If we don't have a max length on the field we should have one too tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol protocol team tickets streamline
Projects
None yet
Development

No branches or pull requests

2 participants