Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bibleBooks.txt CSV file remains largely unchecked #5

Open
skreutzer opened this issue Feb 11, 2015 · 2 comments
Open

bibleBooks.txt CSV file remains largely unchecked #5

skreutzer opened this issue Feb 11, 2015 · 2 comments

Comments

@skreutzer
Copy link
Contributor

No or little checking takes place for the bibleBooks.txt CSV file. If the file gets modified by the user. A trailing newline at the end of the file or missing CSV fields would cause IndexOutOfBoundsExceptions without a hint that a bad bibleBooks.txt file caused the problem. The program might skip incomplete lines and just give a notice, or abort program execution. I think this issue is of low priority as users aren't expected to modify bibleBooks.txt all too often.

@schierlm
Copy link
Collaborator

As we now have a --book command line option, I cannot think of any use case for manually editing bibleBooks.txt file. Especially since editing that file will also break cross references to other books.

@patrickbkr
Copy link
Member

For the sake of being nice to our future selves that have to debug an error by modifying bibleBooks.txt I do not object some error checking code. PRs welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants