omni_gettradehistoryforaddress : Add blocktime for each match in matches array of JSON response
#1264
Comments
|
PR #1270 looks good! |
dexX7
added a commit
that referenced
this issue
Oct 25, 2022
Pull request description: This pull request adds `blocktime` to `omni_gettrade`, `omni_gettradehistoryforaddress` and `omni_gettradehistoryforpair`. This resolves #1264.
counos
pushed a commit
to CounosH/counoslayer
that referenced
this issue
Sep 27, 2023
Pull request description: This pull request adds `blocktime` to `omni_gettrade`, `omni_gettradehistoryforaddress` and `omni_gettradehistoryforpair`. This resolves OmniLayer#1264. # Conflicts: # src/counoscore/rpc.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When trying to build a list of all DEX matching transactions for an Omni Core wallet, the
omni_gettradehistoryforaddressmethod is very useful. However, in order to get a timestamp for each matching transaction an additional call for each match must be made to get the transaction (block) time.Adding a
blocktimeproperty to each object in thematchesarray would eliminate the need for these extra calls. (Theblocktimeproperty in the root object is theblocktimefor the sell offer, but we also need the time for each matching transaction.)It might also make sense to add a
blocktimeproperty to each match in the response toomni_gettradehistoryforpair.The text was updated successfully, but these errors were encountered: