Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refocus on location when not used for some time #1003

Open
JasonGore opened this issue Jul 16, 2019 · 1 comment
Open

Refocus on location when not used for some time #1003

JasonGore opened this issue Jul 16, 2019 · 1 comment
Milestone

Comments

@JasonGore
Copy link

Summary:

App should focus on location when I've moved or haven't used it in some time.

Steps to reproduce:

  1. Use app for morning commute focusing on morning bus stop.
  2. Resume app hours later from work for evening commute.
  3. Use app again for morning commute.

App will still be focused on morning commute. This is a neverending chain so when I use it the next morning the app is also focused on my evening commute stop.

Expected behavior:

When I resume the app and have moved a long distance or haven't used it for hours it should update to my current location.

Observed behavior:

App is still focused on previous location. It seems the app only focuses on location on "cold start". My phone has a ton of RAM and since the app never gets fully destroyed, the app never zooms to my current location when I resume the app.

Device and Android version:

App Version: 2.5.3
Model: SM-G975U1 (Samsung Galaxy S10+)
OS Version: 9 / 28
Google Play Services App: 17.7.85 (100400-253824076)
Google Play Services Library: 12451000

@barbeau
Copy link
Member

barbeau commented Jul 16, 2019

@JasonGore Thanks for opening this! Yes, that sounds like everything is working as the current code is written (IIRC, I just did a quick look at BaseMapFragment that implements this). We don't currently have a feature that detects amount of time or distance moved and then re-centers the map based on this. Current workaround is to tap the "My location" button, although that results in addition unneeded loading and map movement.

Contributions for this are welcome, although a word of warning that the map center code is complicated because it needs to take into account stop shortcuts on home screen, etc.

@barbeau barbeau added this to the v2.7 milestone Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants