Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip planning - add alerts to trip itinerary, results on map #795

Open
barbeau opened this issue Aug 31, 2017 · 2 comments
Open

Trip planning - add alerts to trip itinerary, results on map #795

barbeau opened this issue Aug 31, 2017 · 2 comments
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Aug 31, 2017

Summary:

It would be nice to show alerts in the trip plan itinerary as well as indicate them in the map view of the trip result

Steps to reproduce:

Plan a trip for a stop that shows an alert when viewing arrival times in ArrivalsListFragment

Expected behavior:

When I plan a trip that includes this stop, the trip plan and view of result on map should show the alert

Observed behavior:

No alerts are shown in trip planning results

Device and Android version:

N/A

@barbeau barbeau added this to the v2.1.x milestone Aug 31, 2017
@barbeau barbeau modified the milestones: v2.2.x, v2.3.x Dec 21, 2017
@barbeau barbeau modified the milestones: v2.3.x, v2.5 Apr 12, 2019
@barbeau barbeau modified the milestones: v2.5, v2.6 Jul 11, 2019
@Seattlerider
Copy link

I'm in the Puget Sound region, and recently trip alerts have started blocking view of the continued next arrivals section (i.e. more than the top 2) if there are too many. Because alerts are apparently layered above next arrivals, all you can do is start hiding alerts until they no longer completely cover the pane for next arrivals. If it's feasible, please consider making alerts the top entries in next arrivals, instead of their own pane that covers next arrivals? And regardless, thank you much for all the work you've put in.
Screenshot_2022-01-18-14-12-02

@barbeau
Copy link
Member Author

barbeau commented Jan 19, 2022

@Seattlerider Thanks for the feedback! I know this is frustrating given the amount of service agencies are needing to cancel due to COVID 19.

As you said, for a workaround, you can hide the alerts by tapping on them and then tapping on the "hide" button. But you can only do that one at a time. Having this many alerts active at a time is definitely unprecedented.

I’m also looking at ways to improve the app going forward to make this easier to navigate, although given I work on the app mostly as a volunteer for the Open Transit Software Foundation it may not happen quickly. The current behavior is largely due to the limitations of the Android libraries that were available back when this was first implemented. The app really needs an overhaul to the most recent Android tools and libraries, but that's unfortunately not a quick change.

Ideally most of these alerts would instead be communicated as trip-level cancellations to the app so they could be displayed inline with other arrivals. I implemented most of the code for this in this PR:
#1034

79491263-3071df80-7fec-11ea-93da-a6723b312b00

But it still requires some server side support that's not implemented yet. That would fall on Sound Transit's side of things and I've reached out to them to see if we can make it happen.

Note there is a related issue at #1041 for making the method to hide the alerts more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants