Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome extension in rare cases does not detect the already-signed-in case #384

Open
mttwc opened this issue Oct 14, 2017 · 0 comments
Open

Comments

@mttwc
Copy link
Contributor

mttwc commented Oct 14, 2017

To repro:

a) Sign out of on onenote.com/hrd and clipper
b) Open tab, open clipper
c) Open onenote.com/hrd in another tab, sign in
d) Try signing into clipper using the same sign in option (e.g., work email)
e) The sign in window pops up and goes away and nothing happens

This is because we try and listen for a window redirect. Instead the window detects the auth cookies are present and closes immediately. We think that the user closed the window.

The likely solution here is to hit /userinfo if redirect has not been detected anyway. /userinfo will be the source of truth, not redirectOccurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant