Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Still wrong Popup sizes from OneSignal on MacOs (designed for iPad) #1533

Open
1 task done
sabiland opened this issue Jan 3, 2025 · 3 comments
Open
1 task done

Comments

@sabiland
Copy link

sabiland commented Jan 3, 2025

What happened?

5.2.9 still shows wrong OneSignal popup sizes on MacOs Designed for iPad apps.

Steps to reproduce?

1) Try running on mac (designed for iPad) target any OneSignal action/trigger to show some popup (rating, etc.).
2) Size of the popup is wrong (huge)

What did you expect to happen?

I expected the OneSignal Popup would be within the window bounds.

Screenshot 2025-01-03 at 09 29 34

OneSignal iOS SDK version

Release 5.2.9

iOS version

17

Specific iOS version

* iOS 18.1

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nan-li
Copy link
Contributor

nan-li commented Jan 8, 2025

Hi @sabiland, thanks for reporting. A few questions while we look into this:

  1. Are you seeing the appropriate size for this same in-app message on other platforms? ie: iOS / iPad / Mac Catalystc, etc
  2. Does this wrong size always occur if you test other in-app messages?

@nan-li
Copy link
Contributor

nan-li commented Jan 8, 2025

Hi @sabiland after looking again at the SDK, in-app messages are currently not supported on Mac due to this display issue.

We did not update the SDK code after Apple Silicon macs became available which is why the in-app message is displaying. We will need to make the fix to not display in-app messages on all Macs.

@sabiland
Copy link
Author

sabiland commented Jan 9, 2025

On iPhone and iPad everything is ok. Only on macOS popup sizes are not appropriate size. But they should stay on macOS! Because my app can be run on macOS as designed-for-iPad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants