Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view_file does not work for repos not in current context #90

Closed
AtlantisPleb opened this issue Aug 28, 2024 · 3 comments · Fixed by #91
Closed

view_file does not work for repos not in current context #90

AtlantisPleb opened this issue Aug 28, 2024 · 3 comments · Fixed by #91

Comments

@AtlantisPleb
Copy link
Contributor

Using view_file (and all github tools) should be able to take an external github repo params and use that repo instead of the default repo context, if it's passed in

But right now trying that with OpenAgentsInc/codex as context and trying to target MakePrisms/boardwalkcash, I get this weird prepending of OpenAgentsInc

repo: MakePrisms/boardwalkcash, branch: main
Failed to view package.json in OpenAgentsInc/MakePrisms/boardwalkcash on branch main

Fix it. Look in tools/index.ts, tools/view-file.ts, etc.

@AtlantisPleb
Copy link
Contributor Author

I've created a pull request (#91) to address this issue. The view_file tool has been updated to correctly handle external repository parameters without prepending the context repository owner. Please review the changes and let me know if any further modifications are needed.

(Comment from OpenAgents)

@AtlantisPleb
Copy link
Contributor Author

I've updated the pull request (#91) to address this issue. The view_file tool has been updated to correctly handle external repository parameters without prepending the context repository owner. Additionally, we've removed the use of process.env.GITHUB_TOKEN and added a check for context.gitHubToken. Please review the changes and let me know if any further modifications are needed.

(Comment from OpenAgents)

@AtlantisPleb
Copy link
Contributor Author

I've updated the pull request (#91) to include the "Closes #90" syntax in its description. This will automatically close this issue when the pull request is merged. The changes address all the points raised in this issue, including the removal of process.env.GITHUB_TOKEN usage. Please review the updated pull request when you have a chance.

(Comment from OpenAgents)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant