Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a "Open the app on this device" link when the QR code is shown on a mobile device #342

Open
pmeulen opened this issue Jan 21, 2025 · 0 comments · May be fixed by #346
Open

Show a "Open the app on this device" link when the QR code is shown on a mobile device #342

pmeulen opened this issue Jan 21, 2025 · 0 comments · May be fixed by #346
Assignees
Labels

Comments

@pmeulen
Copy link
Member

pmeulen commented Jan 21, 2025

When a user does an a Tiqr authentication or enrollment on the device where the Tiqr app is installed the user cannot scan the QR code. Instead the user must open a link by tapping on the QR code. This are no visual or other UI cues that that a user. We want to improve this because with the anti MFA fatigue measures implemented in #316 users will need to login using the QR code more often, especially on mobile for apps that use a webview where the persistent device cookies is not shared.

We want to use the same solution as the eduID.nl uses (i.e. https://github.com/OpenConext/OpenConext-myconext):

  1. Detect whether this is a mobile device: https://github.com/OpenConext/OpenConext-myconext/blob/e9b183a37b65762ffa0cabaa0405ec3b41454262/account-gui/src/routes/EnrollApp.svelte#L18

  2. Show a "Open the app on this device" / "Open de app op dit apparaat" button under the QR code: https://github.com/OpenConext/OpenConext-myconext/blob/e9b183a37b65762ffa0cabaa0405ec3b41454262/account-gui/src/routes/EnrollApp.svelte#L109-L120

Screenshot of this in action during a mobile login to eduID.nl:

Image

When implementing this take care not to break browsers with limited functionality like those used by desktop apps that use an embedded browser, assume Internet Explorer level functionality.

@pmeulen pmeulen moved this from New to Backlog in PHP development Jan 21, 2025
@phavekes phavekes added the tiqr label Jan 22, 2025
@johanib johanib moved this from Backlog to In Progress in PHP development Jan 30, 2025
johanib added a commit that referenced this issue Jan 30, 2025
Prior to this change, it was not clear users could tap the qr code on mobile.
This change adds a button to touch-enabled browsers to ensure an optimal UX.

Fixes #342
@johanib johanib linked a pull request Jan 30, 2025 that will close this issue
johanib added a commit that referenced this issue Jan 30, 2025
Prior to this change, it was not clear users could tap the qr code on mobile.
This change adds a button to touch-enabled browsers to ensure an optimal UX.

Fixes #342
johanib added a commit that referenced this issue Jan 30, 2025
Prior to this change, it was not clear users could tap the qr code on mobile.
This change adds a button to touch-enabled browsers to ensure an optimal UX.

Fixes #342
johanib added a commit that referenced this issue Jan 30, 2025
Prior to this change, it was not clear users could tap the qr code on mobile.
This change adds a button to touch-enabled browsers to ensure an optimal UX.

Fixes #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants