You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2054 revealed that we had a few optimizations that were never applied, and once that was fixed one of them still didn't work optimally due to how the optimizer functions.
Ideally, we would create some new unit tests that takes bytecode (or DM code?), peephole optimizes it, and then compares the outputted bytecode to an expected output.
Note that we need to be mindful of not using peephole optimizer opcodes in the inputted bytecode, or we may get another situation where PushNull -> Assign -> Pop is only compiled to PushNull -> AssignPop instead of being reduced to just NullRef.
The text was updated successfully, but these errors were encountered:
#2054 revealed that we had a few optimizations that were never applied, and once that was fixed one of them still didn't work optimally due to how the optimizer functions.
Ideally, we would create some new unit tests that takes bytecode (or DM code?), peephole optimizes it, and then compares the outputted bytecode to an expected output.
Note that we need to be mindful of not using peephole optimizer opcodes in the inputted bytecode, or we may get another situation where
PushNull -> Assign -> Pop
is only compiled toPushNull -> AssignPop
instead of being reduced to justNullRef
.The text was updated successfully, but these errors were encountered: