Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests about more metadata on the variables #100

Open
jerabaul29 opened this issue Sep 2, 2024 · 7 comments
Open

requests about more metadata on the variables #100

jerabaul29 opened this issue Sep 2, 2024 · 7 comments
Labels

Comments

@jerabaul29
Copy link
Collaborator

From the data management group:

"
If you do not have standard_name for variables, please always add long_name. "Unit " should be "units". I'm getting quite few errors when trying to validate (https://compliance.ioos.us/index.html), and I can't visualize in panoply. Are your data supposed to be visualised as trajectory?
"

I guess this should be part of trajan so this is automatically done? :) I will try to add this in a PR :) .

@jerabaul29
Copy link
Collaborator Author

Also from them:

"
"Unit " should be "units".
"

@gauteh
Copy link
Member

gauteh commented Sep 2, 2024

Related to: #78 and #90.

@gauteh gauteh added the cf-spec label Sep 2, 2024
@knutfrode
Copy link
Contributor

knutfrode commented Sep 2, 2024

Yes, I corrected now attribute name unit to units at several places in the code:
#101

Otherwise I believe standard_name attributes should be correct for the core variables (e.g. lontitude, latitude, time), however seems to be missing for the more specialized variables e.g. in reader_omb (#78)

@jerabaul29
Copy link
Collaborator Author

jerabaul29 commented Sep 2, 2024

Should be fixed in PR #102 for the OMB reader :) .

@gauteh
Copy link
Member

gauteh commented Sep 2, 2024

I think a bunch of them have standard names, it is just that I wrote long_name rather than standard_name in the sfy code.

@gauteh
Copy link
Member

gauteh commented Sep 2, 2024

the frequency bins should be a coordinate variable to the spectrum.

@jerabaul29
Copy link
Collaborator Author

I have used standard names where I could find them, and long names when I had to make custom stuff :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants