Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker: Adaptor logs shouldn't log to gcloud #602

Closed
josephjclark opened this issue Feb 15, 2024 · 0 comments
Closed

Worker: Adaptor logs shouldn't log to gcloud #602

josephjclark opened this issue Feb 15, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

The newly fixed adaptor logs are logging to stdout in the worker, which means they get logged to gcloud.

We should treat adaptor logs the same as job logs. Since they may have sensitive data in them, we should not log them to stdout.

This is an easy fix, likely a 1.0.1 patch (although if I have time I'll sneak it into the release)
@github-project-automation github-project-automation bot moved this to New Issues in v2 Feb 15, 2024
@josephjclark josephjclark mentioned this issue Feb 15, 2024
Merged
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
v2
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephjclark