Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide warning on config files that are not currently configured for the project #236

Open
evie-lau opened this issue Oct 25, 2023 · 0 comments
Labels
enhancement New feature or request LCLS Liberty Config Language Server

Comments

@evie-lau
Copy link
Member

evie-lau commented Oct 25, 2023

Following up on discussion in #213 (comment), with the change to allow LCLS support for all bootstrap.properties and server.env files, it is possible to start editing files that have not yet been configured for the Liberty project to use.

Suggestion for enhancement to provide a warning if the currently edited file is not configured for Liberty to use.

Needs design discussion

  • Diagnostic probably won't work because there is no particular text to highlight.
  • Could possibly provide a toast/popup notification.

This would also be affected by the fact that liberty-plugin-config.xml may not have been generated yet in a new or cleaned project, which may raise the warning until the project is built (liberty:create). An idea has been raised to possibly automatically run a lightweight mvn/gradle goal to generate the liberty-plugin-config.xml

@evie-lau evie-lau added enhancement New feature or request LCLS Liberty Config Language Server labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LCLS Liberty Config Language Server
Projects
None yet
Development

No branches or pull requests

1 participant